From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751327AbdJWFyG (ORCPT <rfc822;w@1wt.eu>);
        Mon, 23 Oct 2017 01:54:06 -0400
Received: from mailout3.samsung.com ([203.254.224.33]:52618 "EHLO
        mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751083AbdJWFyE (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 23 Oct 2017 01:54:04 -0400
DKIM-Filter: OpenDKIM Filter v2.11.0 mailout3.samsung.com 20171023055402epoutp03620847284daff951e16bdfed532ce325~wHUGRzEoN1448514485epoutp03D
X-AuditID: b6c32a46-46dff700000010ca-4b-59ed83fa082e
MIME-version: 1.0
Content-transfer-encoding: 8BIT
Content-type: text/plain; charset="utf-8"
Message-id: <59ED83FA.5000701@samsung.com>
Date: Mon, 23 Oct 2017 14:54:02 +0900
From: Chanwoo Choi <cw00.choi@samsung.com>
Organization: Samsung Electronics
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101
        Thunderbird/31.6.0
To: SF Markus Elfring <elfring@users.sourceforge.net>,
        kernel-janitors@vger.kernel.org
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
        Krzysztof Kozlowski <krzk@kernel.org>,
        MyungJoo Ham <myungjoo.ham@samsung.com>,
        LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] extcon: max14577: Use common error handling code in
 max14577_muic_set_path()
In-reply-to: <dda9c1c2-79ec-398e-40ed-a11e894e138b@users.sourceforge.net>
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrEKsWRmVeSWpSXmKPExsWy7bCmhe6v5reRBvv/C1lsnLGe1eJ853Jm
        i623pC3On9/AbnF51xw2i9uNK9gc2Dw2repk8+jbsorRo+lUO6vH501yASxRqTYZqYkpqUUK
        qXnJ+SmZeem2St7B8c7xpmYGhrqGlhbmSgp5ibmptkouPgG6bpk5QLuVFMoSc0qBQgGJxcVK
        +nY2RfmlJakKGfnFJbZK0YaGRnqGBuZ6RkZGeibGsVZGpkAlCakZu382sxa8Z6mYNKeFvYHx
        PXMXIyeHhICJRE/zPrYuRi4OIYEdjBKrHi9lh3C+M0rMnHuaCabq9pb7UFUbGCXePtgDluAV
        EJT4MfkeSxcjBwezgLzEkUvZIGFmAU2JF18msUDU32OUOPDqBgtEvZZE194ORhCbRUBV4kzX
        XDCbDSi+/8UNNhCbX0BR4uqPx2BxUYEIiZ3zv7GD2CJA9t1la5hBhjILbGSU+PF2JdgPwgLp
        Es8aJoAdxCngKfHh+iZGkCIJgR1sEjtuHWSEeMFFYv3zC1BPC0u8Or6FHcKWlni2aiNUQzuj
        xOY591ggnA5GifsrG1khqowlTnU1MkE8xyfRcfgvO8jPEgK8Eh1tQhAlHhIPW9cwQYQdJQ7P
        0YF4fzeTxNllT1gnMMrNQgqxWYgQm4UUYgsYmVcxiqUWFOempxYbFRjpFSfmFpfmpesl5+du
        YgSnNy23HYxLzvkcYhTgYFTi4WUwfBspxJpYVlyZe4hRgoNZSYR3jgVQiDclsbIqtSg/vqg0
        J7X4EKMpMMAnMkuJJucDU29eSbyhiaWBiZmZkbmZBTCJifPWbbsWISSQnliSmp2aWpBaBNPH
        xMEp1cB4pWh3+r1Z0U5zTmh3Zyn0M4f3H+mey5Oy5/TffZtnaHE88pAuCmCcVnnv563Hxrwv
        WEyzmF88OpYx+3Pb+ouyvMH2uT7tzh3zHLxPpX3fsCRRJlN+3d8Z+6K578yY6rPrZclBnbOC
        yb92K8vPfsRQzdO+KmzL2eusr+vvaP32ncy9ctlRllNFSizFGYmGWsxFxYkAvp2aCYUDAAA=
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrELMWRmVeSWpSXmKPExsVy+t9jQd1fzW8jDSYuYLPYOGM9q8X5zuXM
        FltvSVucP7+B3eLyrjlsFrcbV7A5sHlsWtXJ5tG3ZRWjR9OpdlaPz5vkAliiuGxSUnMyy1KL
        9O0SuDJ2/2xmLXjPUjFpTgt7A+N75i5GTg4JAROJ21vus3UxcnEICaxjlPhzeiYjSIJXQFDi
        x+R7LF2MHBzMAvISRy5lQ5jqElOm5EKUP2CUWPr7OztEuZZE194OsFYWAVWJM11zwWw2oPj+
        FzfYQGx+AUWJqz8eM4LMERWIkOg+UQkSFgEyO34dZAWZySywkVFi9uwvYL3CAukSzxomMEEs
        280kcbZrI9jRnAKeEh+ub2KcwCgwC8mpsxBOnYVw6gJG5lWMkqkFxbnpucVGBUZ5qeV6xYm5
        xaV56XrJ+bmbGIEhve2wVv8OxsdL4g8xCnAwKvHwMhi+jRRiTSwrrsw9xCjBwawkwjvHAijE
        m5JYWZValB9fVJqTWnyIUZqDRUmclz//WKSQQHpiSWp2ampBahFMlomDU6qB0YpVS750xVXb
        M8X7N97XfuwnmfaoeeONnm/3puxzWCqg+m/jh8Nh7rtY8g3P/5uZZ316aXFSA7vXNq8zk2pO
        TKi8Olf7433ZiXZaNVOyP4dXuGiV3g//8tH3pYyzYto9fwulrz+CX6/MyEpWCFP+K/VomW2c
        UqndO3H3yfzON8qEu47yRkQsVWIpzkg01GIuKk4EAPIYs0dlAgAA
X-CMS-MailID: 20171023055402epcas2p46fa9e93c57e328787cff4d0f5bf8912d
X-Msg-Generator: CA
CMS-TYPE: 102P
DLP-Filter: Pass
X-CFilter-Loop: Reflected
X-CMS-RootMailID: 20171022175126epcas2p1a0b5b09f6294470b5c3f6c23c2a0f7e4
X-RootMTR: 20171022175126epcas2p1a0b5b09f6294470b5c3f6c23c2a0f7e4
References: <d08cbbf6-015a-ab76-6491-126901d1dda6@users.sourceforge.net>
        <CGME20171022175126epcas2p1a0b5b09f6294470b5c3f6c23c2a0f7e4@epcas2p1.samsung.com>
        <5cdefd84-066d-5379-43c8-76f5d3b8f7c4@users.sourceforge.net>
        <59ED3E72.7010401@samsung.com>
        <dda9c1c2-79ec-398e-40ed-a11e894e138b@users.sourceforge.net>
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2017년 10월 23일 14:45, SF Markus Elfring wrote:
>> As you commented, this patch might remove the redundant error message.
>> But, it makes the code more complicated in side of readability.
> 
> Do you try to avoid duplicated code any more in other circumstances?

I usually used the goto statement on following cases:
- Return the value (error number if fail or 0 if success)
- Do free or unregister or remove operations when error happen.

I think that there is any benefit of this patch.
Also, as I commented, it make the code more complicated.

-- 
Best Regards,
Chanwoo Choi
Samsung Electronics