From: jeffy <jeffy.chen@rock-chips.com>
To: Brian Norris <briannorris@chromium.org>
Cc: linux-kernel@vger.kernel.org, bhelgaas@google.com,
linux-pm@vger.kernel.org, tony@atomide.com,
shawn.lin@rock-chips.com, rjw@rjwysocki.net,
dianders@chromium.org, linux-pci@vger.kernel.org
Subject: Re: [RFC PATCH v8 7/7] PCI / PM: Add support for the PCIe WAKE# signal for OF
Date: Fri, 27 Oct 2017 15:32:52 +0800 [thread overview]
Message-ID: <59F2E124.5060209@rock-chips.com> (raw)
In-Reply-To: <20171027055529.GB85582@google.com>
Hi Brian,
On 10/27/2017 01:55 PM, Brian Norris wrote:
> One reason this series is failing for me: the above is failing with
> -EINVAL -- it seems like no one set the 'can_wakeup' flag for the
> Marvell Wifi card I'm using. It seems like we probably*should* be
> calling device_set_wakeup_capable() from your new setup method, to say
> that we're capable of wakeup. The PCI PME code does this already, which
> seems to make sense. There are also some network drivers that do it too
> (e.g., ath10k), but not all.
>
right, thanks for noticing, will fix it in the new version...
and Sinan suggested to separate of code and wakeirq handling, would it
make sense to rewrite this as pci-wakeirq.c(platform_pm_ops based on
irq), and move of parse code into drivers/of/(maybe into
of_irq_parse_pci()'s PCI interrupt parsing code)?
> Brian
>
prev parent reply other threads:[~2017-10-27 7:33 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-26 13:28 [RFC PATCH v8 0/7] PCI: rockchip: Move PCIe WAKE# handling into pci core Jeffy Chen
2017-10-26 13:28 ` [RFC PATCH v8 1/7] dt-bindings: PCI: Add definition of PCIe WAKE# irq and PCI irq Jeffy Chen
2017-10-27 2:33 ` Brian Norris
2017-10-27 3:06 ` jeffy
2017-10-27 5:40 ` Brian Norris
2017-10-27 5:57 ` jeffy
2017-10-26 13:28 ` [RFC PATCH v8 2/7] mwifiex: Disable wakeup irq handling for pcie Jeffy Chen
2017-10-26 13:28 ` [RFC PATCH v8 3/7] arm64: dts: rockchip: Handle PCIe WAKE# signal in pcie driver for Gru Jeffy Chen
2017-10-26 13:28 ` [RFC PATCH v8 4/7] of/irq: Adjust of pci irq parsing for multiple interrupts Jeffy Chen
2017-10-26 20:02 ` Rob Herring
2017-10-27 2:05 ` jeffy
2017-10-27 14:38 ` Rob Herring
2017-10-30 2:05 ` jeffy
2017-10-30 18:46 ` Brian Norris
2017-10-26 13:28 ` [RFC PATCH v8 5/7] PCI: Make pci_platform_pm_ops's callbacks optional Jeffy Chen
2017-10-26 13:28 ` [RFC PATCH v8 6/7] PCI / PM: Move acpi wakeup code to pci core Jeffy Chen
2017-10-26 13:28 ` [RFC PATCH v8 7/7] PCI / PM: Add support for the PCIe WAKE# signal for OF Jeffy Chen
2017-10-26 14:42 ` Tony Lindgren
2017-10-27 7:37 ` jeffy
2017-10-26 15:16 ` Sinan Kaya
2017-10-27 2:09 ` jeffy
2017-10-28 0:04 ` Brian Norris
2017-10-28 18:01 ` Sinan Kaya
2017-10-28 20:39 ` Brian Norris
2017-10-27 5:55 ` Brian Norris
2017-10-27 7:32 ` jeffy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59F2E124.5060209@rock-chips.com \
--to=jeffy.chen@rock-chips.com \
--cc=bhelgaas@google.com \
--cc=briannorris@chromium.org \
--cc=dianders@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=shawn.lin@rock-chips.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).