From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751948AbdJ3CGK (ORCPT <rfc822;w@1wt.eu>);
        Sun, 29 Oct 2017 22:06:10 -0400
Received: from regular1.263xmail.com ([211.150.99.137]:33901 "EHLO
        regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751772AbdJ3CGF (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 29 Oct 2017 22:06:05 -0400
X-263anti-spam: KSV:0;
X-MAIL-GRAY: 0
X-MAIL-DELIVERY: 1
X-KSVirus-check: 0
X-ABS-CHECKED: 4
X-RL-SENDER: jeffy.chen@rock-chips.com
X-FST-TO: robh@kernel.org
X-SENDER-IP: 103.29.142.67
X-LOGIN-NAME: jeffy.chen@rock-chips.com
X-UNIQUE-TAG: <84df502a38a8a3ae9c40906f1e1ad3d9>
X-ATTACHMENT-NUM: 0
X-DNS-TYPE: 0
Message-ID: <59F688FF.9020806@rock-chips.com>
Date: Mon, 30 Oct 2017 10:05:51 +0800
From: jeffy <jeffy.chen@rock-chips.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:19.0) Gecko/20130126 Thunderbird/19.0
MIME-Version: 1.0
To: Rob Herring <robh@kernel.org>
CC: linux-kernel@vger.kernel.org, bhelgaas@google.com,
        linux-pm@vger.kernel.org, tony@atomide.com, shawn.lin@rock-chips.com,
        briannorris@chromium.org, rjw@rjwysocki.net, dianders@chromium.org,
        Frank Rowand <frowand.list@gmail.com>, devicetree@vger.kernel.org
Subject: Re: [RFC PATCH v8 4/7] of/irq: Adjust of pci irq parsing for multiple
 interrupts
References: <20171026132840.20946-1-jeffy.chen@rock-chips.com> <20171026132840.20946-5-jeffy.chen@rock-chips.com> <20171027143812.5i4vathfjpgld7wk@rob-hp-laptop>
In-Reply-To: <20171027143812.5i4vathfjpgld7wk@rob-hp-laptop>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Rob,

On 10/27/2017 10:38 PM, Rob Herring wrote:
>> +		prop = of_find_property(dn, "interrupt-names", NULL);
>> >+		for (name = of_prop_next_string(prop, NULL); name;
>> >+		     name = of_prop_next_string(prop, name), index++) {
>> >+			if (!strcmp(name, "pci"))
>> >+				break;
> Use of_property_match_string
>
i'm trying to find the first unnamed or "pci" named irq in the string 
array, so cannot use that API:)

but will change to of_property_for_each_string as Brian suggested.