From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753161AbdJ3Lhe (ORCPT ); Mon, 30 Oct 2017 07:37:34 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:9479 "EHLO szxga04-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752821AbdJ3Lhd (ORCPT ); Mon, 30 Oct 2017 07:37:33 -0400 Message-ID: <59F70E4F.6070805@huawei.com> Date: Mon, 30 Oct 2017 19:34:39 +0800 From: Bixuan Cui User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130801 Thunderbird/17.0.8 MIME-Version: 1.0 To: Masami Hiramatsu CC: , "Libin (Huawei)" , "kangwen (A)" , "Leizhen (ThunderTown)" , , , Subject: Re: [PATCH] kernel/kprobes: add check to avoid memory leaks References: <59F08398.3020707@huawei.com> <59F67C21.7020806@huawei.com> <20171030134221.b2c17e36d4deb78a431a0067@kernel.org> In-Reply-To: <20171030134221.b2c17e36d4deb78a431a0067@kernel.org> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.177.222.129] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020206.59F70EEB.0165,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 779d397d494aaa28a6ad3ecfb7589022 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017/10/30 12:42, Masami Hiramatsu wrote: > I don't like this kind of check, since this is obviously caller's bug. > Why doesn't each caller check this? Thank you for your answer. Thanks, Bixuan Cui