From: zhouchengming <zhouchengming1@huawei.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Masami Hiramatsu <mhiramat@kernel.org>,
Ingo Molnar <mingo@redhat.com>, <ananth@linux.vnet.ibm.com>,
<anil.s.keshavamurthy@intel.com>, <davem@davemloft.net>,
<hpa@zytor.com>, <tglx@linutronix.de>, <bp@suse.de>,
<peterz@infradead.org>, <jkosina@suse.cz>, <mjurczyk@google.com>,
<x86@kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] kprobes, x86/alternatives: use text_mutex to protect smp_alt_modules
Date: Wed, 1 Nov 2017 09:48:58 +0800 [thread overview]
Message-ID: <59F9280A.70202@huawei.com> (raw)
In-Reply-To: <20171031175928.1d1d7a6b@gandalf.local.home>
On 2017/11/1 5:59, Steven Rostedt wrote:
> On Mon, 30 Oct 2017 17:03:23 +0900
> Masami Hiramatsu<mhiramat@kernel.org> wrote:
>
>>> static LIST_HEAD(smp_alt_modules);
>>> -static DEFINE_MUTEX(smp_alt);
>>> -static bool uniproc_patched = false; /* protected by smp_alt */
>>> +static bool uniproc_patched = false; /* protected by text_mutex */
> We should also add a comment somewhere by the text_mutex that it is
> protecting this on x86.
Good, I will send a patch-v2 adding this comment.
Thanks!
> -- Steve
>
> .
>
prev parent reply other threads:[~2017-11-01 1:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-27 9:34 [PATCH] kprobes, x86/alternatives: use text_mutex to protect smp_alt_modules Zhou Chengming
2017-10-27 11:15 ` Borislav Petkov
2017-10-27 11:42 ` zhouchengming
2017-10-27 12:33 ` Borislav Petkov
2017-10-27 13:30 ` zhouchengming
2017-10-28 8:43 ` Masami Hiramatsu
2017-10-28 9:51 ` zhouchengming
2017-10-27 14:15 ` Peter Zijlstra
2017-10-28 1:26 ` zhouchengming
2017-10-28 8:44 ` Masami Hiramatsu
2017-10-30 8:03 ` Masami Hiramatsu
2017-10-31 21:59 ` Steven Rostedt
2017-11-01 1:48 ` zhouchengming [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59F9280A.70202@huawei.com \
--to=zhouchengming1@huawei.com \
--cc=ananth@linux.vnet.ibm.com \
--cc=anil.s.keshavamurthy@intel.com \
--cc=bp@suse.de \
--cc=davem@davemloft.net \
--cc=hpa@zytor.com \
--cc=jkosina@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=mjurczyk@google.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox