From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S933144AbdKAByb (ORCPT <rfc822;w@1wt.eu>);
        Tue, 31 Oct 2017 21:54:31 -0400
Received: from szxga05-in.huawei.com ([45.249.212.191]:9549 "EHLO
        szxga05-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S932210AbdKABy3 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 31 Oct 2017 21:54:29 -0400
Message-ID: <59F9280A.70202@huawei.com>
Date: Wed, 1 Nov 2017 09:48:58 +0800
From: zhouchengming <zhouchengming1@huawei.com>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:12.0) Gecko/20120428 Thunderbird/12.0.1
MIME-Version: 1.0
To: Steven Rostedt <rostedt@goodmis.org>
CC: Masami Hiramatsu <mhiramat@kernel.org>, Ingo Molnar <mingo@redhat.com>,
        <ananth@linux.vnet.ibm.com>, <anil.s.keshavamurthy@intel.com>,
        <davem@davemloft.net>, <hpa@zytor.com>, <tglx@linutronix.de>,
        <bp@suse.de>, <peterz@infradead.org>, <jkosina@suse.cz>,
        <mjurczyk@google.com>, <x86@kernel.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] kprobes, x86/alternatives: use text_mutex to protect
 smp_alt_modules
References: <1509096884-22993-1-git-send-email-zhouchengming1@huawei.com> <20171030170323.12610b7d04e739e6cb4c4ec0@kernel.org> <20171031175928.1d1d7a6b@gandalf.local.home>
In-Reply-To: <20171031175928.1d1d7a6b@gandalf.local.home>
Content-Type: text/plain; charset="ISO-8859-1"; format=flowed
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.177.236.183]
X-CFilter-Loop: Reflected
X-Mirapoint-Virus-RAPID-Raw: score=unknown(0),
        refid=str=0001.0A090206.59F92861.00B3,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0,
        ip=0.0.0.0,
        so=2014-11-16 11:51:01,
        dmn=2013-03-21 17:37:32
X-Mirapoint-Loop-Id: 513f511b97ff327a9e3858ac7e2aafb9
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2017/11/1 5:59, Steven Rostedt wrote:
> On Mon, 30 Oct 2017 17:03:23 +0900
> Masami Hiramatsu<mhiramat@kernel.org>  wrote:
>
>>>   static LIST_HEAD(smp_alt_modules);
>>> -static DEFINE_MUTEX(smp_alt);
>>> -static bool uniproc_patched = false;	/* protected by smp_alt */
>>> +static bool uniproc_patched = false;	/* protected by text_mutex */
> We should also add a comment somewhere by the text_mutex that it is
> protecting this on x86.

Good, I will send a patch-v2 adding this comment.

Thanks!

> -- Steve
>
> .
>