From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934636AbdKBWUr (ORCPT ); Thu, 2 Nov 2017 18:20:47 -0400 Received: from www62.your-server.de ([213.133.104.62]:36490 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934536AbdKBWUp (ORCPT ); Thu, 2 Nov 2017 18:20:45 -0400 Message-ID: <59FB9A32.10802@iogearbox.net> Date: Thu, 02 Nov 2017 23:20:34 +0100 From: Daniel Borkmann User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Colin King , Alexei Starovoitov , Jamal Hadi Salim , Cong Wang , Jiri Pirko , "David S . Miller" , netdev@vger.kernel.org CC: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][net-next] net: sched: cls_bpf: use bitwise & rather than logical && on gen_flags References: <20171102200412.16757-1-colin.king@canonical.com> In-Reply-To: <20171102200412.16757-1-colin.king@canonical.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated-Sender: daniel@iogearbox.net Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/02/2017 09:04 PM, Colin King wrote: > From: Colin Ian King > > Currently gen_flags is being operated on by a logical && operator rather > than a bitwise & operator. This looks incorrect as these should be bit > flag operations. Fix this. > > Detected by CoverityScan, CID#1460305 ("Logical vs. bitwise operator") > > Fixes: 3f7889c4c79b ("net: sched: cls_bpf: call block callbacks for offload) > Signed-off-by: Colin Ian King Acked-by: Daniel Borkmann