From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752664AbdKDQkf (ORCPT ); Sat, 4 Nov 2017 12:40:35 -0400 Received: from mail-wm0-f51.google.com ([74.125.82.51]:48190 "EHLO mail-wm0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752552AbdKDQkd (ORCPT ); Sat, 4 Nov 2017 12:40:33 -0400 X-Google-Smtp-Source: ABhQp+Tm5m4JkdfLWl4lyDWb9Rxx9fQUih42DkbD9O1zbc7nwn19lP7w6Whl6H+9Fv6FpKbBDwb8tQ== Message-ID: <59FDED7E.8030100@baylibre.com> Date: Sat, 04 Nov 2017 17:40:30 +0100 From: Neil Armstrong User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Yixun Lan , Jerome Brunet CC: Michael Turquette , Stephen Boyd , Carlo Caione , Kevin Hilman , linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] clk: meson: gxbb: fix wrong clock for SARADC References: <20171103181703.30434-1-yixun.lan@amlogic.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Yixun, Le 04/11/2017 09:41, Yixun Lan a écrit : > > > On 11/04/17 02:17, Yixun Lan wrote: >> According to the datasheet, the clock gate bit for >> SARADC is bit[22] in Meson-GXBB/GXL series. >> >> Change-Id: Ic4fa58276d2a9ea273eef0a08541fc213ac5ac89 >> Signed-off-by: Yixun Lan >> --- >> drivers/clk/meson/gxbb.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/clk/meson/gxbb.c b/drivers/clk/meson/gxbb.c >> index b2d1e8ed7152..4f5b535fcd12 100644 >> --- a/drivers/clk/meson/gxbb.c >> +++ b/drivers/clk/meson/gxbb.c >> @@ -1139,7 +1139,6 @@ static MESON_GATE(gxbb_pl301, HHI_GCLK_MPEG0, 6); >> static MESON_GATE(gxbb_periphs, HHI_GCLK_MPEG0, 7); >> static MESON_GATE(gxbb_spicc, HHI_GCLK_MPEG0, 8); >> static MESON_GATE(gxbb_i2c, HHI_GCLK_MPEG0, 9); >> -static MESON_GATE(gxbb_sar_adc, HHI_GCLK_MPEG0, 10); >> static MESON_GATE(gxbb_smart_card, HHI_GCLK_MPEG0, 11); >> static MESON_GATE(gxbb_rng0, HHI_GCLK_MPEG0, 12); >> static MESON_GATE(gxbb_uart0, HHI_GCLK_MPEG0, 13); >> @@ -1149,6 +1148,7 @@ static MESON_GATE(gxbb_async_fifo, HHI_GCLK_MPEG0, 16); >> static MESON_GATE(gxbb_sdio, HHI_GCLK_MPEG0, 17); >> static MESON_GATE(gxbb_abuf, HHI_GCLK_MPEG0, 18); >> static MESON_GATE(gxbb_hiu_iface, HHI_GCLK_MPEG0, 19); >> +static MESON_GATE(gxbb_sar_adc, HHI_GCLK_MPEG0, 22); >> static MESON_GATE(gxbb_assist_misc, HHI_GCLK_MPEG0, 23); >> static MESON_GATE(gxbb_emmc_a, HHI_GCLK_MPEG0, 24); >> static MESON_GATE(gxbb_emmc_b, HHI_GCLK_MPEG0, 25); >> > Hi Neil > I assume you will take this via the clk-meson tree.. > could you amend the commit msg and drop the 'Change-Id'? > (for other parts, please feel free to adjust if you see fit) > thanks Yes, I will push it as a fix. Can you check if the saradc driver is still functional when applied ? Neil > > Yixun >