From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751350AbdKEWle (ORCPT ); Sun, 5 Nov 2017 17:41:34 -0500 Received: from mailout3.samsung.com ([203.254.224.33]:30097 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750724AbdKEWlc (ORCPT ); Sun, 5 Nov 2017 17:41:32 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 mailout3.samsung.com 20171105224129epoutp034d6d60e79b8b667085957d3349bc15b7~0UcbfRhme0538405384epoutp03f X-AuditID: b6c32a46-455ff700000010ca-28-59ff9398c9ad MIME-version: 1.0 Content-transfer-encoding: 8BIT Content-type: text/plain; charset="UTF-8" Message-id: <59FF9399.6010305@samsung.com> Date: Mon, 06 Nov 2017 07:41:29 +0900 From: Chanwoo Choi Organization: Samsung Electronics User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Bjorn Andersson , MyungJoo Ham , Kyungmin Park Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] PM / devfreq: Propagate error from devfreq_add_device() In-reply-to: <20171104033828.16773-1-bjorn.andersson@linaro.org> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrJKsWRmVeSWpSXmKPExsWy7bCmqe6Myf8jDWY81bc4vf8di8XZpjfs Fpd3zWGz+Nx7hNHiduMKNgdWjzvX9rB59G1ZxejxeZNcAHNUqk1GamJKapFCal5yfkpmXrqt kndwvHO8qZmBoa6hpYW5kkJeYm6qrZKLT4CuW2YO0EolhbLEnFKgUEBicbGSvp1NUX5pSapC Rn5xia1StKGhkZ6hgbmekZGRnolxrJWRKVBJQmrGn203mAuWclUsaZ3L3sB4kKOLkZNDQsBE 4uLX4+xdjFwcQgI7GCVW/vrGBuF8Z5SYcGshI0zV97fzoap2M0psWd/DBpLgFRCU+DH5HksX IwcHs4C8xJFL2SBhZgFNia2710PV32OU2PnqNSNEvZZE25NfLCA2i4CqxIXOC6wgNhtQfP+L G2Az+QUUJa7+eAxWLyoQIbFz/jewQSICbYwSTZ/uMEJssJJ4/bGbHcQWFvCROHl3DlicU8BB 4vW/1WANEgJb2CTWzNnBAvGCi8T+th2sELawxKvjW9ghbGmJZ6s2MkI0tDNKbJ4D8g6I08Eo cX9lI1SHscSprkYmiNV8Eh2H/7KD/CwhwCvR0SYEYXpIdPb5QlQ7Sjy9eIgZ4v3JjBL/tr5j msAoNwspxGYhQmwWUogtYGRexSiWWlCcm55abFRgpFecmFtcmpeul5yfu4kRnMy03HYwLjnn c4hRgINRiYe3wO1fpBBrYllxZe4hRgkOZiUR3qWy/yOFeFMSK6tSi/Lji0pzUosPMZoCA3wi s5Rocj4w0eaVxBuaWBqYmJkZmZtZAJOYOG/dtmsRQgLpiSWp2ampBalFMH1MHJxSDYwBRx4e u7JJ6tbOHXtiz82wXv7i1PTGE428thabVq9ormv4ueBGqoj+xakc3k3dLN+Wiqzl78+Ytva1 87ZFURsrJCadXB7jWuap+4PnUDMPQ+AGU751Ar3LJ+W6FrcxJQb6t4ZKv19nvHzfE86uywmX r9qvjzP1LPreE+aRW8R236PFMyJW64USS3FGoqEWc1FxIgBv6uF5fAMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrNLMWRmVeSWpSXmKPExsVy+t9jAd0Zk/9HGiz6K2Vxev87FouzTW/Y LS7vmsNm8bn3CKPF7cYVbA6sHneu7WHz6NuyitHj8ya5AOYoLpuU1JzMstQifbsErow/224w FyzlqljSOpe9gfEgRxcjJ4eEgInE97fz2bsYuTiEBHYySjy5/ZQNJMErICjxY/I9li5GDg5m AXmJI5eyQcLMAuoSk+YtYoaof8Ao0bKuG6peS6LtyS8WEJtFQFXiQucFVhCbDSi+/8UNsBp+ AUWJqz8eM4LMFBWIkOg+UQkyR0Sgg1Fi97krLBALrCRef+xmB7GFBXwkTt6dwwixbCqjxORX E8CKOAUcJF7/W80+gVFgFpJbZyHcOgvJrQsYmVcxSqYWFOem5xYbFRjlpZbrFSfmFpfmpesl 5+duYgQG8bbDWv07GB8viT/EKMDBqMTDe8LjX6QQa2JZcWXuIUYJDmYlEd6lsv8jhXhTEiur Uovy44tKc1KLDzFKc7AoifPy5x+LFBJITyxJzU5NLUgtgskycXBKNTBum7thjYTq7UuHv/2T eWUW93nDQz+5O9d6nV2OJ0TX/13i1pK/I2HpysdnsgTttu3zWDCZPfzq3fPbQ3bM1fX8Whbt eO6PouDG6sL27nM3vmXdu2/w382zWbTg0Ieo5QJJYWGfHixfG9od+fD5XZW6ryw2R094f+Oe cW5T2/XMkNZJKUWFRfOPKbEUZyQaajEXFScCAHVogIleAgAA X-CMS-MailID: 20171105224128epcas2p3ce2d051e08a1cb611cb7318b3ee8e5dd X-Msg-Generator: CA CMS-TYPE: 102P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20171104033835epcas3p2a0e62915bf40aab150c78b4a3d341b13 X-RootMTR: 20171104033835epcas3p2a0e62915bf40aab150c78b4a3d341b13 References: <20171104033828.16773-1-bjorn.andersson@linaro.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 2017년 11월 04일 12:38, Bjorn Andersson wrote: > Propagate the error of devfreq_add_device() in devm_devfreq_add_device() > rather than statically returning ENOMEM. This makes it slightly faster > to pinpoint the cause of a returned error. > > Signed-off-by: Bjorn Andersson > --- > drivers/devfreq/devfreq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c > index 78fb496ecb4e..99c4021fc33b 100644 > --- a/drivers/devfreq/devfreq.c > +++ b/drivers/devfreq/devfreq.c > @@ -737,7 +737,7 @@ struct devfreq *devm_devfreq_add_device(struct device *dev, > devfreq = devfreq_add_device(dev, profile, governor_name, data); > if (IS_ERR(devfreq)) { > devres_free(ptr); > - return ERR_PTR(-ENOMEM); > + return devfreq; > } > > *ptr = devfreq; > Looks good to me. Acked-by: Chanwoo Choi But, you better to send this patch to the 'stable@vger.kernel.org' with the fixes information as following: Fixes: 8cd84092d35e ("PM / devfreq: Add resource-managed function for devfreq device") Cc: stable@vger.kernel.org Signed-off-by: Bjorn Andersson -- Best Regards, Chanwoo Choi Samsung Electronics