From: Stephen Boyd <sboyd@kernel.org>
To: Henry Martin <bsdhenrymartin@gmail.com>, dave.stevenson@raspberrypi.com
Cc: mturquette@baylibre.com, florian.fainelli@broadcom.com,
bcm-kernel-feedback-list@broadcom.com, popcornmix@gmail.com,
mripard@kernel.org, u.kleine-koenig@baylibre.com,
linux-clk@vger.kernel.org, linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, nathan@kernel.org,
Henry Martin <bsdhenrymartin@gmail.com>
Subject: Re: [PATCH v2] clk: bcm: rpi: Add NULL check in raspberrypi_clk_register()
Date: Tue, 06 May 2025 14:42:14 -0700 [thread overview]
Message-ID: <59c3c160b99f2cfce17d644534591952@kernel.org> (raw)
In-Reply-To: <20250402020513.42628-1-bsdhenrymartin@gmail.com>
Quoting Henry Martin (2025-04-01 19:05:13)
> devm_kasprintf() returns NULL when memory allocation fails. Currently,
> raspberrypi_clk_register() does not check for this case, which results
> in a NULL pointer dereference.
>
> Add NULL check after devm_kasprintf() to prevent this issue.
>
> Fixes: 93d2725affd6 ("clk: bcm: rpi: Discover the firmware clocks")
> Signed-off-by: Henry Martin <bsdhenrymartin@gmail.com>
> Reviewed-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
> ---
Applied to clk-next
prev parent reply other threads:[~2025-05-06 21:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-01 13:23 [PATCH v1] clk: bcm: Add NULL check in raspberrypi_clk_register() Henry Martin
2025-04-01 18:02 ` Dave Stevenson
2025-04-02 2:05 ` [PATCH v2] clk: bcm: rpi: " Henry Martin
2025-04-17 10:08 ` Stefan Wahren
2025-04-17 10:17 ` henry martin
2025-05-06 21:42 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59c3c160b99f2cfce17d644534591952@kernel.org \
--to=sboyd@kernel.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bsdhenrymartin@gmail.com \
--cc=dave.stevenson@raspberrypi.com \
--cc=florian.fainelli@broadcom.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=mripard@kernel.org \
--cc=mturquette@baylibre.com \
--cc=nathan@kernel.org \
--cc=popcornmix@gmail.com \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox