From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756498AbdKGC51 (ORCPT ); Mon, 6 Nov 2017 21:57:27 -0500 Received: from mga03.intel.com ([134.134.136.65]:43072 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750941AbdKGC50 (ORCPT ); Mon, 6 Nov 2017 21:57:26 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,355,1505804400"; d="scan'208";a="1215081179" Subject: Re: [PATCH 1/3] iommu/vt-d: Missing checks for pasid tables if allocation fails To: Alex Williamson References: <1508373556-5340-1-git-send-email-baolu.lu@linux.intel.com> <20171106131309.6bc1084a@t450s.home> Cc: joro@8bytes.org, dwmw2@infradead.org, iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org From: Lu Baolu Message-ID: <5A012114.40701@linux.intel.com> Date: Tue, 7 Nov 2017 10:57:24 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20171106131309.6bc1084a@t450s.home> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 11/07/2017 04:13 AM, Alex Williamson wrote: > On Thu, 19 Oct 2017 08:39:14 +0800 > Lu Baolu wrote: > >> intel_svm_alloc_pasid_tables() might return an error but never be >> checked by the callers. Later when intel_svm_bind_mm() is called, >> there are no checks for valid pasid tables before enabling them. >> >> Signed-off-by: Ashok Raj >> Signed-off-by: Lu Baolu >> --- >> drivers/iommu/intel-svm.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/iommu/intel-svm.c b/drivers/iommu/intel-svm.c >> index f6697e5..43280ca 100644 >> --- a/drivers/iommu/intel-svm.c >> +++ b/drivers/iommu/intel-svm.c >> @@ -292,7 +292,7 @@ int intel_svm_bind_mm(struct device *dev, int *pasid, int flags, struct svm_dev_ >> int pasid_max; >> int ret; >> >> - if (WARN_ON(!iommu)) >> + if (WARN_ON(!iommu || !iommu->pasid_table)) >> return -EINVAL; >> >> if (dev_is_pci(dev)) { > Applied series to iommu/vt-d for v4.15. Thanks, > > Alex > Thank you, Alex. Best regards, Lu Baolu