* [PATCH] PM / devfreq: Remove unnecessary NULL check before kfree
@ 2017-11-12 8:27 ` Gustavo A. R. Silva
2017-11-12 22:28 ` Chanwoo Choi
0 siblings, 1 reply; 2+ messages in thread
From: Gustavo A. R. Silva @ 2017-11-12 8:27 UTC (permalink / raw)
To: MyungJoo Ham, Kyungmin Park, Chanwoo Choi
Cc: linux-pm, linux-kernel, Gustavo A. R. Silva
NULL check before freeing functions like kfree is not needed.
This issue was detected with the help of Coccinelle.
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
---
drivers/devfreq/devfreq.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
index 78fb496..21164a9 100644
--- a/drivers/devfreq/devfreq.c
+++ b/drivers/devfreq/devfreq.c
@@ -672,8 +672,7 @@ struct devfreq *devfreq_add_device(struct device *dev,
device_unregister(&devfreq->dev);
err_dev:
- if (devfreq)
- kfree(devfreq);
+ kfree(devfreq);
err_out:
return ERR_PTR(err);
}
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] PM / devfreq: Remove unnecessary NULL check before kfree
2017-11-12 8:27 ` [PATCH] PM / devfreq: Remove unnecessary NULL check before kfree Gustavo A. R. Silva
@ 2017-11-12 22:28 ` Chanwoo Choi
0 siblings, 0 replies; 2+ messages in thread
From: Chanwoo Choi @ 2017-11-12 22:28 UTC (permalink / raw)
To: Gustavo A. R. Silva, MyungJoo Ham, Kyungmin Park; +Cc: linux-pm, linux-kernel
Hi,
On 2017년 11월 12일 17:27, Gustavo A. R. Silva wrote:
> NULL check before freeing functions like kfree is not needed.
>
> This issue was detected with the help of Coccinelle.
>
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
> ---
> drivers/devfreq/devfreq.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
> index 78fb496..21164a9 100644
> --- a/drivers/devfreq/devfreq.c
> +++ b/drivers/devfreq/devfreq.c
> @@ -672,8 +672,7 @@ struct devfreq *devfreq_add_device(struct device *dev,
>
> device_unregister(&devfreq->dev);
> err_dev:
> - if (devfreq)
> - kfree(devfreq);
> + kfree(devfreq);
> err_out:
> return ERR_PTR(err);
> }
>
It prevents the memory leak when the registration
of devfreq device is failed. You can check the
detailed reason on patch1[1].
[1] PM / devfreq: Fix memory leak when fail to register device
- https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=9e14de1077e9c34f141cf98bdba60cdd5193d962
--
Best Regards,
Chanwoo Choi
Samsung Electronics
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-11-12 22:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20171112082944epcas5p216efba5e38d3bf17ee993abe51aa4dc3@epcas5p2.samsung.com>
2017-11-12 8:27 ` [PATCH] PM / devfreq: Remove unnecessary NULL check before kfree Gustavo A. R. Silva
2017-11-12 22:28 ` Chanwoo Choi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox