From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933726AbdKQGg3 (ORCPT ); Fri, 17 Nov 2017 01:36:29 -0500 Received: from mail-it0-f66.google.com ([209.85.214.66]:46457 "EHLO mail-it0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933699AbdKQGgM (ORCPT ); Fri, 17 Nov 2017 01:36:12 -0500 X-Google-Smtp-Source: AGs4zMaZw+C1xUWUwHrs+hloAUB5Tc4bFwZ1O+MFA4ZfSrrOE8/AhPcnWLXSPDxfadnYHZavH5gtdw== Subject: Re: [PATCH] staging: comedi: ni_atmio: Handle return value of pnp_* To: Ian Abbott , hsweeten@visionengravers.com, gregkh@linuxfoundation.org References: <35855327607952b24d97e7f7374a1115f400dd8c.1510806666.git.arvind.yadav.cs@gmail.com> Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org From: arvindY Message-ID: <5A0E8357.3070306@gmail.com> Date: Fri, 17 Nov 2017 12:06:07 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org hi, On Thursday 16 November 2017 07:27 PM, Ian Abbott wrote: > On 16/11/17 04:32, Arvind Yadav wrote: >> pnp_irq() and pnp_port_start() can fail here and we must check >> its return value. >> >> Signed-off-by: Arvind Yadav >> --- >> drivers/staging/comedi/drivers/ni_atmio.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/drivers/staging/comedi/drivers/ni_atmio.c >> b/drivers/staging/comedi/drivers/ni_atmio.c >> index 2d62a8c..dead159 100644 >> --- a/drivers/staging/comedi/drivers/ni_atmio.c >> +++ b/drivers/staging/comedi/drivers/ni_atmio.c >> @@ -308,6 +308,9 @@ static int ni_atmio_attach(struct comedi_device >> *dev, >> iobase = pnp_port_start(isapnp_dev, 0); >> irq = pnp_irq(isapnp_dev, 0); >> + if (irq == -1 || !iobase) >> + return -ENOMEM; >> + >> comedi_set_hw_dev(dev, &isapnp_dev->dev); >> } >> > > Can they fail here? ni_isapnp_find_board() has already checked they > are valid. Yes, you are right. It will not fail. ~arvind