From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752145AbdKWBp0 (ORCPT ); Wed, 22 Nov 2017 20:45:26 -0500 Received: from mailout1.samsung.com ([203.254.224.24]:10619 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751985AbdKWBpY (ORCPT ); Wed, 22 Nov 2017 20:45:24 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.samsung.com 20171123014522epoutp01409d9331452c0eadbbc09cfb4afef2a7~5k61R0u491504115041epoutp01W X-AuditID: b6c32a48-92fff700000010df-e8-5a162831252a MIME-version: 1.0 Content-transfer-encoding: 8BIT Content-type: text/plain; charset="utf-8" Message-id: <5A162835.5050806@samsung.com> Date: Thu, 23 Nov 2017 10:45:25 +0900 From: Chanwoo Choi Organization: Samsung Electronics User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: myungjoo.ham@samsung.com, Joe Perches , Kyungmin Park Cc: "linux-pm@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 1/4] rk3399_dmc: Fix line continuation format In-reply-to: <20171123012100epcms1p13f78950557de06dbbd65996c8b0645ee@epcms1p1> X-Brightmail-Tracker: H4sIAAAAAAAAA01Sa0hTYRj225lnR3F2nE5fDNQORGm4trXprOwqMUpMkMCMsJN+ueFu7Mwo iWj+SJE0K4pSu/hjWcPI1NSSbhYVDSPtQmJpOTIJycS1FLI621Hy3/M+7/PeHl6KkH0NjaeM Fge2W1gTQ4aLOx8na1PVK2MLlD6fSNcw4hXr+iomJLrXdxtJ3XTNE6Qbcl4jN4Xqfe53hL62 w430020JuUQBXm/AbDG2J2FLkbXYaCnJZHbkFW4t1KYpVamqDF06k2RhzTiTycrOTd1mNPEj maSDrKmMp3JZjmNWb1hvt5Y5cJLByjkymT0qlVqhUqYr1Gq1QrNm71q1lpfswwZXz6TENhp1 yFX7kTiGXJHVKIwCWgNP708R1SicktHdCP6ODSIh+IXA/cITuqDqu9clFhKtCOZGn4sDCSkd BTNnhnlMUQSdCE8GSgM0QSfDuO/0vH4YQXfXSULQp0DNeA8KYDG9HJwXbgX7kDz/YPw9GcBL 6GXwdsYb1MjpfLhz2S8J4BjaAHX+JlIYUA6e/uvB5aLpzdD8+W9QH0bngPfXxfmlW0m48REC uwGdBQ3P8gU6Gr4965AIeCmMuW8FDwa6EkF747BYCKoQjFx3zjdaAy+qnSJhcCRUPZ6TCE2l UHVcJkj0UOn/TQp4MzzomSSF49+IoHpqVlKHEuoX+VX/36/6RX5dQYQbxWIbZy7BnNqmUXCs mSuzlCiKrOY2FHyyFH03evgyuxfRFGIipNca5QWyUPYgd9jci4AimBhp3hWekhazh8ux3Vpo LzNhrhdpebtPEfHyIiv/shZHoUqTodSkpanT03T8g8VJj3a+y5fRJawDl2Jsw/aFOhEVFn8M tXzQdmkGb9q+OJtDBkYN2R56j37ottyT6Dr7KFJu/eTtGdDtHmx3bY87WrdrS9u5vZ0JjZfP vzoRkbN/9iUOzw45sCp6wJS1UVJhFB1J2NKf/J3cedXpK91dUfNTYi6f+hOnfOMfZlekPPRO t1ZOXPL3+awrE38bm35krmsp9ZgYMWdgVSmEnWP/AZyiQbR6AwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrBLMWRmVeSWpSXmKPExsVy+t9jQV1DDbEog1tNxhaz7z9msTjb9Ibd 4vKuOWwWn3uPMFrcblzB5sDq8WXVNWaPvi2rGD0+b5ILYI7isklJzcksSy3St0vgyli6+z17 wSPBiqV9d5kbGJfydTFyckgImEic3budpYuRi0NIYB2jxIvOfWwgCV4BQYkfk+8BJTg4mAXk JY5cyoYw1SWmTMmFKH/AKLH2/DN2iHItid4XuxlBbBYBVYnGmRtZQGw2oPj+FzfARvILKEpc /fGYEWSOqECERPeJSpCwiECGxPUTq1hBbGaBKonduzeBlQsLOEosf/ifEWLXFSaJlzcmgM3k FPCTePx9LusERoFZSC6dhXDpLIRLFzAyr2KUTC0ozk3PLTYqMMpLLdcrTswtLs1L10vOz93E CAzfbYe1+ncwPl4Sf4hRgINRiYeXYb5olBBrYllxZe4hRgkOZiUR3uAFQCHelMTKqtSi/Pii 0pzU4kOM0hwsSuK8/PnHIoUE0hNLUrNTUwtSi2CyTBycUg2MZ1vbvCfYOC241Trhx8U3VXud 5ya4TGyYL/GEe75atYXQLrFtK+pvbVz5R1OE3+jd4jXHOsIKf6s+yOLlP2nks+SR1tf6T08e L/3yzV9w4p6cUwId1mefiu5Y5F+5J7NoY5/b7CkSJT0n1/RKH2I7/vXvpcLuJSpuhl/Fjt/7 M+3Iq72WvG9LpymxFGckGmoxFxUnAgCkfKw0WwIAAA== X-CMS-MailID: 20171123014521epcas2p24ab40f0e00375ca3c7778250e594c79b X-Msg-Generator: CA CMS-TYPE: 102P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20171116152742epcas2p22b17887a4d7f2adcd3beb414988dbce3 X-RootMTR: 20171116152742epcas2p22b17887a4d7f2adcd3beb414988dbce3 References: <1511347280.6989.81.camel@perches.com> <7d659960e45f66894126fba9e2d54cf25ae1185b.1510845910.git.joe@perches.com> <5A150792.6050104@samsung.com> <20171123012100epcms1p13f78950557de06dbbd65996c8b0645ee@epcms1p1> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017년 11월 23일 10:21, MyungJoo Ham wrote: >> On Wed, 2017-11-22 at 14:13 +0900, Chanwoo Choi wrote: >>> On 2017년 11월 17일 00:27, Joe Perches wrote: >>>> Line continuations with excess spacing causes unexpected output. >>>> >>>> Signed-off-by: Joe Perches >>>> --- >>>> drivers/devfreq/rk3399_dmc.c | 4 ++-- >>>> 1 file changed, 2 insertions(+), 2 deletions(-) >>>> >>>> diff --git a/drivers/devfreq/rk3399_dmc.c b/drivers/devfreq/rk3399_dmc.c >>>> index 5dfbfa3cc878..0938c97d46f0 100644 >>>> --- a/drivers/devfreq/rk3399_dmc.c >>>> +++ b/drivers/devfreq/rk3399_dmc.c >>>> @@ -146,8 +146,8 @@ static int rk3399_dmcfreq_target(struct device *dev, unsigned long *freq, >>>> >>>> /* If get the incorrect rate, set voltage to old value. */ >>>> if (dmcfreq->rate != target_rate) { >>>> - dev_err(dev, "Get wrong ddr frequency, Request frequency %lu,\ >>>> - Current frequency %lu\n", target_rate, dmcfreq->rate); >>>> + dev_err(dev, "Get wrong ddr frequency, Request frequency %lu, Current frequency %lu\n", >>>> + target_rate, dmcfreq->rate); >>> >>> IMO, I don't like over 80 char in the one line. >> >> Fix it as you chose, but the code I proposed >> is what is preferred by CodingStyle. >> >> The current code is unintentional. >> >> Right now there are 3 tabs between "Request frequency" >> and "Current frequency" in the output. > > Chanwoo, this is not a simple coding style issue. > I'm seeing these unintentional tabs as well. > > If you want to keep it 80 cols with strings (which is not mandatory for strings in double quotes), > We'd better do: > > - dev_err(dev, "Get wrong ddr frequency, Request frequency %lu,\ > - Current frequency %lu\n", target_rate, dmcfreq->rate); > + dev_err(dev, "Get wrong ddr frequency, Request frequency %lu," > + " Current frequency %lu\n", target_rate, dmcfreq->rate); I agree with Myungjoo's opinion. I think the readability is important. So, I prefer to keep one line within 80 char. > > Cheers, > MyungJoo > >> >>>> regulator_set_voltage(dmcfreq->vdd_center, dmcfreq->volt, >>>> dmcfreq->volt); >>>> goto out; >>>> >>> >>> >> > > > -- Best Regards, Chanwoo Choi Samsung Electronics