From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752297AbdKWCXX (ORCPT ); Wed, 22 Nov 2017 21:23:23 -0500 Received: from mailout4.samsung.com ([203.254.224.34]:30997 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751970AbdKWCXV (ORCPT ); Wed, 22 Nov 2017 21:23:21 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 mailout4.samsung.com 20171123022319epoutp04a5b76893c1210d4bba59b3f1b3cf0531~5lb96l8X53115331153epoutp04t X-AuditID: b6c32a38-ec5ff70000001183-84-5a163116f957 MIME-version: 1.0 Content-transfer-encoding: 8BIT Content-type: text/plain; charset="utf-8" Message-id: <5A163119.1050500@samsung.com> Date: Thu, 23 Nov 2017 11:23:21 +0900 From: Chanwoo Choi Organization: Samsung Electronics User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Joe Perches , myungjoo.ham@samsung.com, Kyungmin Park Cc: "linux-pm@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 1/4] rk3399_dmc: Fix line continuation format In-reply-to: <1511403518.2385.8.camel@perches.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrMKsWRmVeSWpSXmKPExsWy7bCmnq6YoViUwe+Fuhaz7z9msTjb9Ibd 4vKuOWwWn3uPMFrcblzB5sDq8WXVNWaPvi2rGD0+b5ILYI5KtclITUxJLVJIzUvOT8nMS7dV 8g6Od443NTMw1DW0tDBXUshLzE21VXLxCdB1y8wBWqmkUJaYUwoUCkgsLlbSt7Mpyi8tSVXI yC8usVWKNjQ00jM0MNczMjLSMzGOtTIyBSpJSM3oOnmQreC5eMXkfYcZGxhPCXcxcnBICJhI LOpW7mLk4hAS2MEoMftcDwuE851RYufO/0xdjJxgRbPf3WUEsYUEdjNKfNrOD2LzCghK/Jh8 jwVkELOAvMSRS9kgYWYBTYkXXyZBzbnHKHHq7Bc2iHotiX87lrCC2CwCqhLfNiwAm8kGFN// 4gZYDb+AosTVH4/B4qICERI7539jB7FFBDIkfs3aygixoEri9MWVYHOEBRwllj/8zwhyA6eA kcTJ7nqIk9ewScxcGQthu0i8m7mcDcIWlnh1fAs7xO/SEpeO2oKcKSHQziixec49Fging1Hi /spGVogGY4lTXY1MEHv5JN597WGFaOaV6GgTgijxkGj/9gdqvqPE/t3v2SBB9YhZov9y2QRG uVlIoTULEVqzkEJrASPzKkax1ILi3PTUYsMCE73ixNzi0rx0veT83E2M4ASmZbGDcc85n0OM AhyMSjy8K+aIRgmxJpYVV+YeYpTgYFYS4Q1eABTiTUmsrEotyo8vKs1JLT7EaAoM7InMUqLJ +cDkmlcSb2hiaWBiZgRMWpaGhkrivKLrr0UICaQnlqRmp6YWpBbB9DFxcEo1MGr9uuU36WuH pYZhEfOjyzuunpz06M70uSs5Z/vZujZ8++26sn7P7T1Tw9xSN2+SNbna/aU5+W6IevvvDGd9 17Y7V/T1wrz4/q3/6D9Fvzng0ILp1g8PhrxzfT3nh8Y6XW+Oq6LfQ7e81jZ5/rkspnPXUzuR o8ZTItVuyoUlGWbv+/kuuv57t4ESS3FGoqEWc1FxIgAXh/GkdgMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrOLMWRmVeSWpSXmKPExsVy+t9jAV0xQ7EogzlXJS1m33/MYnG26Q27 xeVdc9gsPvceYbS43biCzYHV48uqa8wefVtWMXp83iQXwBzFZZOSmpNZllqkb5fAldF18iBb wXPxisn7DjM2MJ4S7mLk5JAQMJGY/e4uYxcjF4eQwE5GiWuTtrGCJHgFBCV+TL7H0sXIwcEs IC9x5FI2hKkuMWVKLkT5A0aJrys/Q5VrSfzbsQTMZhFQlfi2YQEjiM0GFN//4gYbiM0voChx 9cdjRpA5ogIREt0nKkHCIgIZEt1X3jOB2MwCVRK7d28CKxcWcJRY/vA/1GmPmCX2zV7LCtLL KWAkcbK7fgKjwCwkh85COHQWwqELGJlXMUqmFhTnpucWGxUY5qWW6xUn5haX5qXrJefnbmIE Bu+2w1p9OxjvL4k/xCjAwajEw8swXzRKiDWxrLgy9xCjBAezkghv8AKgEG9KYmVValF+fFFp TmrxIUZpDhYlcd7beccihQTSE0tSs1NTC1KLYLJMHJxSDYwijxmjF+fFcHNue/Ui92Djo5cF fLsVPG10OgU2CO5gN94le+Ag85VPYos+fF7+x5Gp9lRlwdqdbN7MOXeTA6z8zywoFthjwJRp rBVVfPrehaYvESeUbwvvzXi4R/TXxTvXpvAIh6U73xPYtOiO+LaHSdcW8uj/t/BJqj6mYCe/ 8HjsdQ9nFVYlluKMREMt5qLiRAAwSCs7WgIAAA== X-CMS-MailID: 20171123022318epcas1p32f6fa28f9ee9ebbad79bec5ea8c42cdf X-Msg-Generator: CA CMS-TYPE: 101P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20171116152742epcas2p22b17887a4d7f2adcd3beb414988dbce3 X-RootMTR: 20171116152742epcas2p22b17887a4d7f2adcd3beb414988dbce3 References: <1511347280.6989.81.camel@perches.com> <7d659960e45f66894126fba9e2d54cf25ae1185b.1510845910.git.joe@perches.com> <5A150792.6050104@samsung.com> <20171123012100epcms1p13f78950557de06dbbd65996c8b0645ee@epcms1p1> <5A162835.5050806@samsung.com> <1511402826.2385.3.camel@perches.com> <5A162E8A.3040207@samsung.com> <1511403518.2385.8.camel@perches.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017년 11월 23일 11:18, Joe Perches wrote: > On Thu, 2017-11-23 at 11:12 +0900, Chanwoo Choi wrote: >> On 2017년 11월 23일 11:07, Joe Perches wrote: >>> On Thu, 2017-11-23 at 10:45 +0900, Chanwoo Choi wrote: >>>> On 2017년 11월 23일 10:21, MyungJoo Ham wrote: >>>>>> On Wed, 2017-11-22 at 14:13 +0900, Chanwoo Choi wrote: >>>>>>> On 2017년 11월 17일 00:27, Joe Perches wrote: >>>>>>>> Line continuations with excess spacing causes unexpected output. >>>>>>>> >>>>>>>> Signed-off-by: Joe Perches >>>>>>>> --- >>>>>>>> drivers/devfreq/rk3399_dmc.c | 4 ++-- >>>>>>>> 1 file changed, 2 insertions(+), 2 deletions(-) >>>>>>>> >>>>>>>> diff --git a/drivers/devfreq/rk3399_dmc.c b/drivers/devfreq/rk3399_dmc.c >>>>>>>> index 5dfbfa3cc878..0938c97d46f0 100644 >>>>>>>> --- a/drivers/devfreq/rk3399_dmc.c >>>>>>>> +++ b/drivers/devfreq/rk3399_dmc.c >>>>>>>> @@ -146,8 +146,8 @@ static int rk3399_dmcfreq_target(struct device *dev, unsigned long *freq, >>>>>>>> >>>>>>>> /* If get the incorrect rate, set voltage to old value. */ >>>>>>>> if (dmcfreq->rate != target_rate) { >>>>>>>> - dev_err(dev, "Get wrong ddr frequency, Request frequency %lu,\ >>>>>>>> - Current frequency %lu\n", target_rate, dmcfreq->rate); >>>>>>>> + dev_err(dev, "Get wrong ddr frequency, Request frequency %lu, Current frequency %lu\n", >>>>>>>> + target_rate, dmcfreq->rate); >>>>>>> >>>>>>> IMO, I don't like over 80 char in the one line. >>>>>> >>>>>> Fix it as you chose, but the code I proposed >>>>>> is what is preferred by CodingStyle. >>>>>> >>>>>> The current code is unintentional. >>>>>> >>>>>> Right now there are 3 tabs between "Request frequency" >>>>>> and "Current frequency" in the output. >>>>> >>>>> Chanwoo, this is not a simple coding style issue. >>>>> I'm seeing these unintentional tabs as well. >>>>> >>>>> >>>>> If you want to keep it 80 cols with strings (which is r mandatory for strings in double quotes), >>>>> We'd better do: >>>>> >>>>> - dev_err(dev, "Get wrong ddr frequency, Request frequency %lu,\ >>>>> - Current frequency %lu\n", target_rate, dmcfreq->rate); >>>>> + dev_err(dev, "Get wrong ddr frequency, Request frequency %lu," >>>>> + " Current frequency %lu\n", target_rate, dmcfreq->rate); >>>> >>>> I agree with Myungjoo's opinion. >>>> I think the readability is important. So, I prefer to keep one line within 80 char. >>> >>> Read Documentation/process/coding-style.rst >>> >>> What I proposed is by far the common style. >>> I think you should get used to it. >> >> Read line.81 in the Documentation/process/coding-style.rst >> - "2) Breaking long lines and strings" >> >> Or, we better to modify the error message within 80 char. > > Exactly! > > line 94: > > never break user-visible strings such as > printk messages, because that breaks the ability to grep for them So, I suggested "Or, we better to modify the error message within 80 char.". -- Best Regards, Chanwoo Choi Samsung Electronics