From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752220AbdKWCfj (ORCPT ); Wed, 22 Nov 2017 21:35:39 -0500 Received: from mailout1.samsung.com ([203.254.224.24]:42307 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752124AbdKWCff (ORCPT ); Wed, 22 Nov 2017 21:35:35 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.samsung.com 20171123023528epoutp01a168d564d4b549c84f46744fa467ff81~5lmkWPgLR2040220402epoutp014 X-AuditID: b6c32a47-5ebff70000001126-83-5a1633ef4344 MIME-version: 1.0 Content-transfer-encoding: 8BIT Content-type: text/plain; charset="utf-8" Message-id: <5A1633F2.6000103@samsung.com> Date: Thu, 23 Nov 2017 11:35:30 +0900 From: Chanwoo Choi Organization: Samsung Electronics User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Joe Perches , myungjoo.ham@samsung.com, Kyungmin Park Cc: "linux-pm@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 1/4] rk3399_dmc: Fix line continuation format In-reply-to: <1511404163.2385.11.camel@perches.com> X-Brightmail-Tracker: H4sIAAAAAAAAA01Se0hTYRzl895tV2l1Wz5+zCi7FKHk2sPNGS6SpIwMBKHECLvOy+Zjj3Y3 Sf+IjCizsodRuhYaCbXRg0xHD0ubgrRKStEMzUdSSVkiWsZK6m5Xqf/Od75zOJzDj8AkEwIp UWi2MzYzXUIJI3BvR7w6cUoVnSt/NrRBe3lkHNe+PDIp0vY+dAm1M6c7kXaw4oZwiyBj1tOP ZVQ3e1DGTNOqLCyXSTUydAFji2PMektBodmgo3Zm523NU2vkikRFijaZijPTJkZHpWdmJW4r LOEiqbhSusTBUVk0y1IbN6faLA47E2e0sHYdtVehUMoU8mSZUqmUJan2bVKqOcl+xthSc0Jg /SY4eKalFzuMevEqFE4AmQQVfaPCKhRBSMj7CFynWhH/mENQ9bZesKi6EHgfxn88QjA93hSy i8nl8LNmmMMEgZGrobOnOEhjZDxMzJ7Hef0wgpv+2jBenwBPXgyEME6ug675nlCAkOPbJgaE QbyMXAN9P8dREEeROfCg/ocoiCNJIwScLYgPKIfnr90h7woyDa6P/Qnx4aQKntZXL1S7KYQ3 LVIep0NPY91CmRXwuatZxONY+Oi5G2oM5HEE91zDOP+oRDDirlhwqMBfVRHGJy+Fyo55UbAx kGKoPCbhJRlw/MdvIY/ToO3R1MKmHhy63K2is2iV87/BnP8Gc/43WAPCPCiasbImA8MqrSoZ S5tYh9kg01tMTSh0ZQnb7yNvd6YPkQSilohvuKJyJQK6lC0z+RAQGBUpzm7gKHEBXVbO2Cx5 NkcJw/qQmtv7HCaN0lu4mzXb8xRJKfIkjUaZrNFyFxYjPuTtz5GQBtrOFDOMlbEt+sKIcOlh lNIRuFVr8qW1t5ceWJs/1ngylvSNOAZzfil7h03yOxpncsDtuzpU9o69HWu44ioyjLrn5N1l MVJ/YYrol1cX723e8aH8O76n1QJRn0pl7vzia1P3dOmjD7Jrd88Wra9TT1fKvxyd/Cq5eKkv 4NhVQCx9rHfvXG99hdrm8v0rKZw10ooEzMbSfwGvVqy5ewMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrGLMWRmVeSWpSXmKPExsVy+t9jAd33xmJRBt0XxSxm33/MYnG26Q27 xeVdc9gsPvceYbS43biCzYHV48uqa8wefVtWMXp83iQXwBzFZZOSmpNZllqkb5fAlbF1cidr wTvWiv6tl5kbGC+zdDFyckgImEhM+fWIqYuRi0NIYCejRMONB+wgCV4BQYkfk+8BFXFwMAvI Sxy5lA1hqktMmZILUiEk8IBRYvJUHohqLYl9Z24wgdgsAqoSx/9eYgWx2YDi+1/cYAOx+QUU Ja7+eMwIMkZUIEKi+0QlSFhEIEOi+8p7sFZmgSqJ3bs3gZULCzhKLH/4nxFi1SoWiVlbk0Bs TgFjiYPz+1gmMArMQnLnLIQ7ZyHcuYCReRWjZGpBcW56brFRgVFearlecWJucWleul5yfu4m RmDobjus1b+D8fGS+EOMAhyMSjy8DPNFo4RYE8uKK3MPMUpwMCuJ8AYvAArxpiRWVqUW5ccX leakFh9ilOZgURLn5c8/FikkkJ5YkpqdmlqQWgSTZeLglGpgzKoXvnl+wytG9VOyVw4f3dY1 7a263Ab9YtbZuwoXnHDOifb3vST4OjV0udoHS8cdBZU/GFneGXSt2Z0oweC6hFPi7G+7c6xC Hz+sjdu+sD1j3rnGmW/EPEp2u/ctfTPZWjvG72LTK3lmo5lGMqfvzm6SPtgx6avU9RVe99SX 8UzgtF17NMTzixJLcUaioRZzUXEiACq6JkdZAgAA X-CMS-MailID: 20171123023527epcas2p14cc4e4b299a2034be2221025f83ccae2 X-Msg-Generator: CA CMS-TYPE: 102P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20171116152742epcas2p22b17887a4d7f2adcd3beb414988dbce3 X-RootMTR: 20171116152742epcas2p22b17887a4d7f2adcd3beb414988dbce3 References: <1511347280.6989.81.camel@perches.com> <7d659960e45f66894126fba9e2d54cf25ae1185b.1510845910.git.joe@perches.com> <5A150792.6050104@samsung.com> <20171123012100epcms1p13f78950557de06dbbd65996c8b0645ee@epcms1p1> <5A162835.5050806@samsung.com> <1511402826.2385.3.camel@perches.com> <5A162E8A.3040207@samsung.com> <1511403518.2385.8.camel@perches.com> <5A163119.1050500@samsung.com> <1511404163.2385.11.camel@perches.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017년 11월 23일 11:29, Joe Perches wrote: > On Thu, 2017-11-23 at 11:23 +0900, Chanwoo Choi wrote: >> On 2017년 11월 23일 11:18, Joe Perches wrote: >>> never break user-visible strings such as >>> printk messages, because that breaks the ability to grep for them >> >> So, I suggested "Or, we better to modify the error message within 80 char.". > > Run checkpatch on your suggestion. > You will get a "split_string" warning. I knew about this. I don't like to hurt the readability in order to fix the warning with the improper way. If you want to fix it, I suggested that you better to modify the error message within 80 char. Or I prefer the Myungjoo's opinion. -- Best Regards, Chanwoo Choi Samsung Electronics