From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753382AbdKXAHs (ORCPT ); Thu, 23 Nov 2017 19:07:48 -0500 Received: from mailout4.samsung.com ([203.254.224.34]:34773 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751613AbdKXAHq (ORCPT ); Thu, 23 Nov 2017 19:07:46 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 mailout4.samsung.com 20171124000745epoutp04e0a5f8f1a464668a2a84b60a78bcfb17~53O4pBI_s2291422914epoutp04P X-AuditID: b6c32a46-995ff700000010ee-cf-5a1762d07c58 MIME-version: 1.0 Content-transfer-encoding: 8BIT Content-type: text/plain; charset="UTF-8" Message-id: <5A1762D4.9020902@samsung.com> Date: Fri, 24 Nov 2017 09:07:48 +0900 From: Chanwoo Choi Organization: Samsung Electronics User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Arvind Yadav , myungjoo.ham@samsung.com, wens@csie.org Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/2] Handle return value and error checking of platform_get_irq In-reply-to: <1511452530-16858-1-git-send-email-arvind.yadav.cs@gmail.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrOKsWRmVeSWpSXmKPExsWy7bCmhe6FJPEogyNfdSyu9S5ktri8aw6b xe3GFWwWPw+dZ3Jg8djwaDWrx85Zd9k9+rasYvT4vEkugCUq1SYjNTEltUghNS85PyUzL91W yTs43jne1MzAUNfQ0sJcSSEvMTfVVsnFJ0DXLTMHaKWSQlliTilQKCCxuFhJ386mKL+0JFUh I7+4xFYp2tDQSM/QwFzPyMhIz8Q41srIFKgkITWjue0HU8Fm1orp7/IbGNewdDFyckgImEhc PLyFsYuRi0NIYAejxI5Hs9kgnO+MEm+/rWeEqTowcRYLRGIDo0Tj5P/MIAleAUGJH5PvASU4 OJgF5CWOXMoGCTMLaEps3b2eHaL+HlD9vd/sEPVaEvv+vWUCqWcRUJVY31YLEmYDCu9/cYMN xOYXUJS4+uMx2F5RgQiJnfO/gbWKCIRLdP3bxgwxX0Hi171NrCC2sECoxMPjL8HqOQW8JNZ0 LAbbKyGwgk1i9tZXzBAPuEhMP7ySCcIWlnh1fAs7hC0t8WzVRkaIhnZGic1z7rFAOB2MEvdX NrJCVBlLnOpqZIJYzSfRcfgvO8gHEgK8Eh1tQhAlHhIdHUehljlK7Lq1gBni+7mMEn8+9bBP YJSbhRRgsxABNgspwBYwMq9iFEstKM5NTy02KjDSK07MLS7NS9dLzs/dxAhOZFpuOxiXnPM5 xCjAwajEw1vwSCxKiDWxrLgy9xCjBAezkgiv/FOgEG9KYmVValF+fFFpTmrxIUZTYHhPZJYS Tc4HJtm8knhDE0sDEzMzI3MzC2ACE+et23YtQkggPbEkNTs1tSC1CKaPiYNTqoHx3PdNU3s7 7K7ZVczM+nXBO0V+c9yqqx95VG5HxenIHMsLchX8sV44TGSypqfEMq0L2SdPr/74Oct66ZnJ ZW8Yrj450nLDzcTu1Fb5e+KzPOasMe2oEN8nucbV/pFim6SNBGfRobTmM9NWn7yhVcZ2/0ec WtHd9cEpf5//4Xd2aVI5s8z6w88kJZbijERDLeai4kQAFGBKonoDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrBLMWRmVeSWpSXmKPExsVy+t9jQd0LSeJRBit2KVpc613IbHF51xw2 i9uNK9gsfh46z+TA4rHh0WpWj52z7rJ79G1ZxejxeZNcAEsUl01Kak5mWWqRvl0CV0Zz2w+m gs2sFdPf5TcwrmHpYuTkkBAwkTgwcRaQzcUhJLCOUaJh+kxWkASvgKDEj8n3gBIcHMwC8hJH LmWDhJkF1CUmzVvEDFH/gFFi8qE2qHotiX3/3jKB1LMIqEqsb6sFCbMBhfe/uMEGYvMLKEpc /fGYEaREVCBCovtEJUhYRCBc4vHvvewQ4xUkft3bBDZRWCBU4uHxl4wQq+YzSvyesBsswSng JbGmYzH7BEaBWUgunYVw6Swkly5gZF7FKJlaUJybnltsVGCUl1quV5yYW1yal66XnJ+7iREY vtsOa/XvYHy8JP4QowAHoxIPb8EjsSgh1sSy4srcQ4wSHMxKIrzyT4FCvCmJlVWpRfnxRaU5 qcWHGKU5WJTEefnzj0UKCaQnlqRmp6YWpBbBZJk4OKUaGFeZrDi4vq3a7RaDz2FP0S3n9KWE wjN/cbN4mFwyFBLl2dUmKLuA99RmA13Vv38jFap9PYOk+4PYNGu3F6Z/iZ4kKmCltKfLJ/ui J7PUieT9/WWmO12CLtxz53kWlF1sHqb5KZ1vvXralIqKxZZXHi46YWlVs6X20Rqef23O/p+E T2vLFYQqsRRnJBpqMRcVJwIAovd7n1sCAAA= X-CMS-MailID: 20171124000744epcas2p1705d8dc280ec000fe295a673b516c116 X-Msg-Generator: CA CMS-TYPE: 102P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20171123155542epcas3p38259ac96b30879770cf72c83d199815b X-RootMTR: 20171123155542epcas3p38259ac96b30879770cf72c83d199815b References: <1511452530-16858-1-git-send-email-arvind.yadav.cs@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017년 11월 24일 00:55, Arvind Yadav wrote: > The platform_get_irq() function returns negative if an error occurs. > zero or positive number on success. platform_get_irq() error checking > for zero is not correct. > platform_get_irq() can fail here and we must check its return value. > > Arvind Yadav (2): > [PATCH 1/2] extcon: adc-jack: Fix platform_get_irq's error checking > [PATCH 2/2] extcon: axp288:: Handle return value of platform_get_irq > > drivers/extcon/extcon-adc-jack.c | 2 +- > drivers/extcon/extcon-axp288.c | 3 +++ > 2 files changed, 4 insertions(+), 1 deletion(-) > Applied them. -- Best Regards, Chanwoo Choi Samsung Electronics