From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752455AbdKXHx6 (ORCPT ); Fri, 24 Nov 2017 02:53:58 -0500 Received: from szxga04-in.huawei.com ([45.249.212.190]:11415 "EHLO szxga04-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751870AbdKXHx5 (ORCPT ); Fri, 24 Nov 2017 02:53:57 -0500 Subject: Re: [PATCH 1/1] Input: ims-pcu - fix typo in an error log To: Joe Perches , Dmitry Torokhov , linux-input , linux-kernel References: <1511506772-21412-1-git-send-email-thunder.leizhen@huawei.com> <1511507823.8230.8.camel@perches.com> CC: Hanjun Guo , Libin , "Kefeng Wang" From: "Leizhen (ThunderTown)" Message-ID: <5A17CF26.5030003@huawei.com> Date: Fri, 24 Nov 2017 15:49:58 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <1511507823.8230.8.camel@perches.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.177.23.164] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A090203.5A17D005.00A2,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: d547c7f7b157e54646a0a3ae6e6c3db6 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017/11/24 15:17, Joe Perches wrote: > On Fri, 2017-11-24 at 14:59 +0800, Zhen Lei wrote: >> Tiny typo fixed in an error log. >> >> I found this when I backported the CVE-2017-16645 patch: >> ea04efee7635 ("Input: ims-psu - check if CDC union descriptor is sane") >> >> Signed-off-by: Zhen Lei >> --- >> drivers/input/misc/ims-pcu.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/input/misc/ims-pcu.c b/drivers/input/misc/ims-pcu.c > [] >> @@ -1651,7 +1651,7 @@ static void ims_pcu_buffers_free(struct ims_pcu *pcu) >> return union_desc; >> >> dev_err(&intf->dev, >> - "Union descriptor to short (%d vs %zd\n)", >> + "Union descriptor too short (%d vs %zd\n)", > > And this format is incorrect too. It should be: > > + "Union descriptor too short (%d vs %zd)\n", > > with the close parenthesis before the newline, not after. You are very observant. Do I need to post v2? It seems that we can simply modify it directly. > > > . > -- Thanks! BestRegards