From: arvindY <arvind.yadav.cs@gmail.com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
b.zolnierkie@samsung.com, tj@kernel.org
Cc: linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org
Subject: Re: [PATCH] pata_pdc2027x: Remove unnecessary error check and coding style error.
Date: Sat, 25 Nov 2017 15:49:33 +0530 [thread overview]
Message-ID: <5A1943B5.2070304@gmail.com> (raw)
In-Reply-To: <4dcd6458-f289-57e0-a921-5e1b00d91800@cogentembedded.com>
Hi Sergei,
On Saturday 25 November 2017 03:30 PM, Sergei Shtylyov wrote:
> On 11/25/2017 7:15 AM, Arvind Yadav wrote:
>
>> Here, The function pdc_hardware_init always return zero. So it is not
>> necessary to check its return value.
>>
>> Fix these checkpatch.pl error:
>>
>> ERROR: space prohibited after that '~' (ctx:WxW)
>> + mask &= ~ (1 << (6 + ATA_SHIFT_UDMA));
>>
>> ERROR: spaces required around that '?' (ctx:VxW)
>> + long pout_required = board_idx? PDC_133_MHZ:PDC_100_MHZ;
>>
>> ERROR: that open brace { should be on the previous line
>> + const struct ata_port_info *ppi[] =
>> + { &pdc2027x_port_info[board_idx], NULL };
>>
>
> Please fix the checkpatch.pl errors in a sperate patch.
Please find a patch v3, which does not include checkpatch.pl error fix.
>
>> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> [...]
>
> MBR, Sergei
~arvind
prev parent reply other threads:[~2017-11-25 10:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-25 4:15 [PATCH] pata_pdc2027x: Remove unnecessary error check and coding style error Arvind Yadav
2017-11-25 4:37 ` Joe Perches
2017-11-25 10:00 ` Sergei Shtylyov
2017-11-25 10:19 ` arvindY [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5A1943B5.2070304@gmail.com \
--to=arvind.yadav.cs@gmail.com \
--cc=b.zolnierkie@samsung.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox