From: "Wei Hu (Xavier)" <xavier.huwei@huawei.com>
To: Jason Gunthorpe <jgg@ziepe.ca>
Cc: <dledford@redhat.com>, <linux-rdma@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <xavier.huwei@tom.com>,
<xavier_huwei@163.com>, <linuxarm@huawei.com>
Subject: Re: [PATCH 0/3] RDMA/hns: Bug fixes in hns RoCE driver
Date: Tue, 28 Nov 2017 14:28:04 +0800 [thread overview]
Message-ID: <5A1D01F4.8000800@huawei.com> (raw)
In-Reply-To: <20171127183637.GA13966@ziepe.ca>
On 2017/11/28 2:36, Jason Gunthorpe wrote:
> On Mon, Nov 27, 2017 at 10:41:21AM +0800, Wei Hu (Xavier) wrote:
>> This patch-set introduces three patches to fix about the memory
>> related issues.
> If these patches are for-rc can you revise the commit message to more
> clearly explain what the bug is, and supply Fixes lines?
Ok, I will modify the commit message and add Fixes lines.
And I will send patch V2 for-rc.
Thanks.
> Otherwise these will go to 4.16
>
> It looks like the first one is for-rc material as it looks like DMA
> will fail sometimes if the smmu is enabled?
Yes, The first one fixes the MTPT configuration error that probably
cause dma operation
failure.
> The other two are less clear to me - is this just fixing the code to
> conform to the DMA API, or is there an actual real user-impacting bug here?
The other two patches fixes incorrect usage of dma API that may
cause coherency problems.
Regards
Wei Hu
> Thanks
> Jason
>
>
prev parent reply other threads:[~2017-11-28 6:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-27 2:41 [PATCH 0/3] RDMA/hns: Bug fixes in hns RoCE driver Wei Hu (Xavier)
2017-11-27 2:41 ` [PATCH 1/3] RDMA/hns: Fix the issue of IOVA not page continuous in hip08 Wei Hu (Xavier)
2017-11-27 2:41 ` [PATCH 2/3] RDMA/hns: Get rid of virt_to_page and vmap calls after dma_alloc_coherent Wei Hu (Xavier)
2017-11-27 2:41 ` [PATCH 3/3] RDMA/hns: Get rid of page operation " Wei Hu (Xavier)
2017-11-27 18:36 ` [PATCH 0/3] RDMA/hns: Bug fixes in hns RoCE driver Jason Gunthorpe
2017-11-28 6:15 ` Leon Romanovsky
2017-11-28 13:20 ` Dennis Dalessandro
2017-11-28 18:39 ` Jason Gunthorpe
2017-11-28 18:50 ` Bart Van Assche
2017-11-28 19:08 ` Leon Romanovsky
2017-11-28 19:33 ` Jason Gunthorpe
2017-11-28 20:27 ` Dennis Dalessandro
2017-11-29 10:00 ` Jonathan Cameron
2017-11-28 6:28 ` Wei Hu (Xavier) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5A1D01F4.8000800@huawei.com \
--to=xavier.huwei@huawei.com \
--cc=dledford@redhat.com \
--cc=jgg@ziepe.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=xavier.huwei@tom.com \
--cc=xavier_huwei@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox