From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751706AbdK1HmU (ORCPT ); Tue, 28 Nov 2017 02:42:20 -0500 Received: from mga09.intel.com ([134.134.136.24]:31020 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751378AbdK1HmT (ORCPT ); Tue, 28 Nov 2017 02:42:19 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,467,1505804400"; d="scan'208";a="6954825" Subject: Re: [PATCH 1/1] usb: early: Correct the endpoint type value for bulk in endpoint To: Greg Kroah-Hartman References: <1511844744-18232-1-git-send-email-baolu.lu@linux.intel.com> <20171128072901.GD10757@kroah.com> Cc: Ingo Molnar , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org From: Lu Baolu Message-ID: <5A1D1356.4060100@linux.intel.com> Date: Tue, 28 Nov 2017 15:42:14 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20171128072901.GD10757@kroah.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 11/28/2017 03:29 PM, Greg Kroah-Hartman wrote: > On Tue, Nov 28, 2017 at 12:52:24PM +0800, Lu Baolu wrote: >> This corrects the endpiont type value set to the DbC bulk in endpoint. >> The previous value doesn't cause any problems because that we now only >> use the bulk out endpoint. Set the hardware with the correct value any >> way. >> >> Signed-off-by: Lu Baolu >> --- >> drivers/usb/early/xhci-dbc.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/usb/early/xhci-dbc.c b/drivers/usb/early/xhci-dbc.c >> index 8a700b4..e15e896 100644 >> --- a/drivers/usb/early/xhci-dbc.c >> +++ b/drivers/usb/early/xhci-dbc.c >> @@ -328,7 +328,7 @@ static void xdbc_mem_init(void) >> ep_in = (struct xdbc_ep_context *)&ctx->in; >> >> ep_in->ep_info1 = 0; >> - ep_in->ep_info2 = cpu_to_le32(EP_TYPE(BULK_OUT_EP) | MAX_PACKET(1024) | MAX_BURST(max_burst)); >> + ep_in->ep_info2 = cpu_to_le32(EP_TYPE(BULK_IN_EP) | MAX_PACKET(1024) | MAX_BURST(max_burst)); > Should this go to the stable kernels? If so, how far back? > This doesn't cause any real problem. We currently only use the bulk-out endpoint for early-printk. So I don't think there is a need to back port it. Best regards, Lu Baolu