From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932116AbdK2IlF (ORCPT ); Wed, 29 Nov 2017 03:41:05 -0500 Received: from mail-ve1eur01on0041.outbound.protection.outlook.com ([104.47.1.41]:32160 "EHLO EUR01-VE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753686AbdK2IlA (ORCPT ); Wed, 29 Nov 2017 03:41:00 -0500 From: Laurentiu Tudor To: Andrew Lunn CC: "gregkh@linuxfoundation.org" , "Ruxandra Ioana Radulescu" , "devel@driverdev.osuosl.org" , Jason Cooper , "stuyoder@gmail.com" , Marc Zyngier , Stuart Yoder , Roy Pledge , "linux-kernel@vger.kernel.org" , Leo Li , Thomas Gleixner , Bogdan Purcareata , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH v3] staging: fsl-mc: move bus driver out of staging Thread-Topic: [PATCH v3] staging: fsl-mc: move bus driver out of staging Thread-Index: AQHTaF2Ah+QNHMijFU+FamkdA1XfJqMp9IOAgAEV6QA= Date: Wed, 29 Nov 2017 08:40:55 +0000 Message-ID: <5A1E7244.5020805@nxp.com> References: <20171128152757.1058-1-laurentiu.tudor@nxp.com> <20171128160451.GC14512@lunn.ch> In-Reply-To: <20171128160451.GC14512@lunn.ch> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=laurentiu.tudor@nxp.com; x-originating-ip: [86.34.165.90] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;VI1PR0401MB1711;6:2JYvejtRARU8MlyjT4zMbtjqHXLCcNXrWlvNduhvjpEJR02tB3iUqRkSZugN+2Qyl965fZ2dHBrNlccgeX+D272LFflmgC9qhk4lrjGITIQEvus9dsnQyCyO1vJMn/OFpkmCS1lOPHMdTdCqMp3YBahitMC1gJQJoVmFfVohyhwEo76bZpca/Mu/2lFZYDOiBTKMRTNkDY0S+flToegh0wSVWVAvIWqnUfwizrUDYCu4lI6ZJPcWtT08qrn3zLNzpXGgFE6XK/KUb/da/Vvk1FYZkaey93PK4DtPfkXO/fNumQZImfd2tzlmFTGY/zCwPjCO1l2FR3KaKP+pmLJoZkLyUNKZHljpDJYm3VgKXkk=;5:gAFRp48sYDr7EHt114FazbpSjiJBKys9MIfsIBeS5vNRkm3KpmU7R5Wke++KERXCfRqqvtOSVpmUpTLzBYjEWv7+IkaxoF1hYM11KHWwio7jGXhXSUh+2zyJzMWXb0s07Sm9jnyCzleK47l1vWU1ncAPAazerzufwr5nppN0bUY=;24:Q4kRmuAZ+onVswHv6eDiNU+SCKW73Cz1TgpPkza0QRaiAa/kh4duOPHvcDZnGNTMjilO6zBo0n96OquCdmbz8TgU8/Gth/EY4KeheQc3IBI=;7:9BC4OrcCXzd3wONgDmAsWyhx+V4XPSg4Hu4PiCgJcAlNkSBL3rAkPSnoyq9wdYTbcJLFd2/PQlgsh5A+5b1BooHDEgVexSYAYwQSSUfp8yyVCC3ctN8dKu44NoklmHqjVFeyKTUMOOQJ/2TNEd9JhXtjCbRv48M4hTqYDXEdyGRYgbKtWalnI+O5Ee2gyVbuMTKrR7DmL4QrO7dAkh7+g31ZDo3VxJKO1ORe9C8z5+7JjrWuR/gZxRz4XTufiJ8Z x-ms-exchange-antispam-srfa-diagnostics: SSOS;SSOR; x-forefront-antispam-report: SFV:SKI;SCL:-1;SFV:NSPM;SFS:(10009020)(6009001)(346002)(376002)(39860400002)(366004)(189002)(199003)(24454002)(53936002)(305945005)(4326008)(2906002)(80316001)(54906003)(99286004)(50986999)(7736002)(229853002)(2950100002)(6436002)(53546010)(36756003)(101416001)(2900100001)(316002)(8936002)(54356999)(14454004)(25786009)(65816999)(87266999)(33656002)(76176999)(6916009)(6506006)(86362001)(106356001)(3280700002)(3660700001)(105586002)(6486002)(6512007)(5250100002)(6246003)(59896002)(6116002)(97736004)(39060400002)(189998001)(102836003)(5660300001)(478600001)(8676002)(68736007)(3846002)(66066001)(81166006)(81156014);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR0401MB1711;H:VI1PR0401MB1856.eurprd04.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 9acc33b5-e963-4ce5-b4ce-08d53704e841 x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(48565401081)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(5600026)(4604075)(2017052603267);SRVR:VI1PR0401MB1711; x-ms-traffictypediagnostic: VI1PR0401MB1711: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(185117386973197); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040450)(2401047)(5005006)(8121501046)(10201501046)(93006095)(93001095)(3002001)(3231022)(6055026)(6041248)(20161123555025)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(20161123558100)(20161123560025)(6072148)(201708071742011);SRVR:VI1PR0401MB1711;BCL:0;PCL:0;RULEID:(100000803101)(100110400095);SRVR:VI1PR0401MB1711; x-forefront-prvs: 05066DEDBB spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="Windows-1252" Content-ID: MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9acc33b5-e963-4ce5-b4ce-08d53704e841 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Nov 2017 08:40:55.7247 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB1711 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id vAT8f9Av030904 Hi Andrew, On 11/28/2017 06:04 PM, Andrew Lunn wrote: > On Tue, Nov 28, 2017 at 05:27:57PM +0200, laurentiu.tudor@nxp.com wrote: >> diff --git a/drivers/staging/fsl-mc/bus/dpmcp.h b/drivers/bus/fsl-mc/dpmcp.h >> similarity index 100% >> rename from drivers/staging/fsl-mc/bus/dpmcp.h >> rename to drivers/bus/fsl-mc/dpmcp.h >> diff --git a/drivers/staging/fsl-mc/bus/dpmng-cmd.h b/drivers/bus/fsl-mc/dpmng-cmd.h >> similarity index 100% >> rename from drivers/staging/fsl-mc/bus/dpmng-cmd.h >> rename to drivers/bus/fsl-mc/dpmng-cmd.h >> diff --git a/drivers/staging/fsl-mc/bus/dprc-cmd.h b/drivers/bus/fsl-mc/dprc-cmd.h >> similarity index 100% >> rename from drivers/staging/fsl-mc/bus/dprc-cmd.h >> rename to drivers/bus/fsl-mc/dprc-cmd.h >> diff --git a/drivers/staging/fsl-mc/bus/dprc-driver.c b/drivers/bus/fsl-mc/dprc-driver.c >> similarity index 99% >> rename from drivers/staging/fsl-mc/bus/dprc-driver.c >> rename to drivers/bus/fsl-mc/dprc-driver.c > > Hi Laurentiu > > It is hard to review code when we don't see it. I'll reformat the patch with rename detection disabled, but please note that it will be pretty big (~370KiB). --- Best Regards, Laurentiu