From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753627AbdK3Qp2 (ORCPT ); Thu, 30 Nov 2017 11:45:28 -0500 Received: from mail-pl0-f65.google.com ([209.85.160.65]:44407 "EHLO mail-pl0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753115AbdK3QpZ (ORCPT ); Thu, 30 Nov 2017 11:45:25 -0500 X-Google-Smtp-Source: AGs4zMY4hx1OhUJ4j23Ero6RvS/opzSEa8xttYPf8+6eOewbnOvUfC062KRCKhQ8iXmXKkL5HcANxw== Subject: Re: [PATCH 2/3] staging: irda: Handle return value of platform_get_irq To: Greg KH References: <1512056616-21065-1-git-send-email-arvind.yadav.cs@gmail.com> <1512056616-21065-3-git-send-email-arvind.yadav.cs@gmail.com> <20171130164124.GB17869@kroah.com> Cc: lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org, knaack.h@gmx.de, pmeerw@pmeerw.net, samuel@sortiz.org, linux-iio@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org From: arvindY Message-ID: <5A20359F.10508@gmail.com> Date: Thu, 30 Nov 2017 22:15:19 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <20171130164124.GB17869@kroah.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Greg, On Thursday 30 November 2017 10:11 PM, Greg KH wrote: > On Thu, Nov 30, 2017 at 09:13:35PM +0530, Arvind Yadav wrote: >> platform_get_irq() can fail here and we must check its return value. >> >> Signed-off-by: Arvind Yadav >> --- >> drivers/staging/irda/drivers/pxaficp_ir.c | 10 ++++++++++ >> 1 file changed, 10 insertions(+) > Did you read drivers/staging/irda/TODO? Sorry, Now I have read it. :( > > thanks, > > greg k-h Thanks, ~arvind