From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751641AbdLHFnH (ORCPT ); Fri, 8 Dec 2017 00:43:07 -0500 Received: from relay1.mentorg.com ([192.94.38.131]:33560 "EHLO relay1.mentorg.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750764AbdLHFnG (ORCPT ); Fri, 8 Dec 2017 00:43:06 -0500 Message-ID: <5A2A2669.4020506@mentor.com> Date: Thu, 7 Dec 2017 21:43:05 -0800 From: Jiada Wang User-Agent: Mozilla/5.0 (X11; Linux i686; rv:11.0) Gecko/20120411 Thunderbird/11.0.1 MIME-Version: 1.0 To: Kuninori Morimoto CC: , , , , , Subject: Re: [PATCH v2 2/2] ASoC: rsnd: ssi: remove unnesessary period_pos References: <1512634956-17760-1-git-send-email-jiada_wang@mentor.com> <1512634956-17760-3-git-send-email-jiada_wang@mentor.com> <87wp1y7trw.wl%kuninori.morimoto.gx@renesas.com> In-Reply-To: <87wp1y7trw.wl%kuninori.morimoto.gx@renesas.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: svr-orw-mbx-08.mgc.mentorg.com (147.34.90.208) To svr-orw-mbx-03.mgc.mentorg.com (147.34.90.203) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Morimoto-san On 12/07/2017 01:58 AM, Kuninori Morimoto wrote: > Hi Jiada > >> Further more, if the passed 'byte' amount to >> rsnd_ssi_pointer_update() is more than byte_per_period. >> the calculation of next_period_byte isn't correct. > Is it really happen ?? > > Basically, I have no objection about this patch, > but this explanation is very strange for me... No, I didn't see the issue, but the implementation of rsnd_ssi_pointer_update(), behaves like it knows all caller will always pass 'byte' no larger than byte_per_period, without any check internally. I am ok to remove this explanation from commit message, what do you think? Thanks, Jiada > Best regards > --- > Kuninori Morimoto