From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750965AbdLUHNJ (ORCPT ); Thu, 21 Dec 2017 02:13:09 -0500 Received: from relay1.mentorg.com ([192.94.38.131]:54991 "EHLO relay1.mentorg.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750797AbdLUHNI (ORCPT ); Thu, 21 Dec 2017 02:13:08 -0500 Message-ID: <5A3B5EFE.8070606@mentor.com> Date: Wed, 20 Dec 2017 23:13:02 -0800 From: Jiada Wang User-Agent: Mozilla/5.0 (X11; Linux i686; rv:11.0) Gecko/20120411 Thunderbird/11.0.1 MIME-Version: 1.0 To: Kuninori Morimoto CC: , , , , , Subject: Re: [PATCH v1 1/1] ASoC: rsnd: ssi: Fix issue in dma data address assignment References: <1513832314-29727-1-git-send-email-jiada_wang@mentor.com> <87k1xgbnfz.wl%kuninori.morimoto.gx@renesas.com> In-Reply-To: <87k1xgbnfz.wl%kuninori.morimoto.gx@renesas.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: svr-orw-mbx-08.mgc.mentorg.com (147.34.90.208) To svr-orw-mbx-03.mgc.mentorg.com (147.34.90.203) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Morimoto-san On 12/20/2017 10:42 PM, Kuninori Morimoto wrote: > Hi Jiada > > Thank you for your patch > >> Same SSI device may be used in different dai links, >> by only having one dma struct in rsnd_ssi, after the first >> instance's dma config be initilized, the following instances >> can no longer configure dma, this causes issue, when their >> dma data address are different from the first instance. >> >> This patch by introduces two dma struct in rdai, each SSI >> instance in a dai link is assigned with two dma struct, >> to store dma configuration for playback and capture. >> >> Signed-off-by: Jiada Wang >> --- > (snip) >> @@ -876,7 +876,7 @@ static int rsnd_ssi_dma_probe(struct rsnd_mod *mod, >> return ret; >> >> /* SSI probe might be called many times in MUX multi path */ >> - ret = rsnd_dma_attach(io, mod,&ssi->dma); >> + ret = rsnd_dma_attach(io, mod,&rdai->dma[is_play]); >> >> return ret; >> } > Some cases, same SSI might be used on different dai links. > In my understanding, it happen if you uses MIXer. > But, are you using same SSI for both playback and capture ?? No, I am not using same SSI in both playback and capture of same dai-link, without this patch, I am seeing issues when rcar sound is working in multi DAI mode, for example with the following configuration diff --git a/arch/arm64/boot/dts/renesas/salvator-common.dtsi b/arch/arm64/boot/dts/renesas/salvator-common.dtsi index a298df7..16f3214 100644 --- a/arch/arm64/boot/dts/renesas/salvator-common.dtsi +++ b/arch/arm64/boot/dts/renesas/salvator-common.dtsi @@ -94,14 +94,24 @@ }; rsnd_ak4613: sound { - compatible = "simple-audio-card"; + compatible = "simple-scu-audio-card"; simple-audio-card,format = "left_j"; simple-audio-card,bitclock-master = <&sndcpu>; simple-audio-card,frame-master = <&sndcpu>; - sndcpu: simple-audio-card,cpu { - sound-dai = <&rcar_sound>; + simple-audio-card,prefix = "ak4613"; + simple-audio-card,routing = + "ak4613 Playback", "DAI0 Playback", + "DAI0 Capture", "ak4613 Capture", + "ak4613 Playback", "DAI1 Playback"; + + sndcpu: simple-audio-card,cpu@0 { + sound-dai = <&rcar_sound 0>; + }; + + simple-audio-card,cpu@1 { + sound-dai = <&rcar_sound 1>; }; sndcodec: simple-audio-card,codec { @@ -517,7 +527,7 @@ pinctrl-names = "default"; /* Single DAI */ - #sound-dai-cells = <0>; + #sound-dai-cells = <1>; /* audio_clkout0/1/2/3 */ #clock-cells = <1>; @@ -549,6 +559,9 @@ playback = <&ssi0 &src0 &dvc0>; capture = <&ssi1 &src1 &dvc1>; }; + dai1 { + playback = <&ssi0>; + }; }; }; playing with dai1 will have issue. Thanks, Jiada > Best regards > --- > Kuninori Morimoto