From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755718AbdLVC1a (ORCPT ); Thu, 21 Dec 2017 21:27:30 -0500 Received: from relay1.mentorg.com ([192.94.38.131]:58547 "EHLO relay1.mentorg.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752385AbdLVC13 (ORCPT ); Thu, 21 Dec 2017 21:27:29 -0500 Message-ID: <5A3C6D87.6080508@mentor.com> Date: Thu, 21 Dec 2017 18:27:19 -0800 From: Jiada Wang User-Agent: Mozilla/5.0 (X11; Linux i686; rv:11.0) Gecko/20120411 Thunderbird/11.0.1 MIME-Version: 1.0 To: Kuninori Morimoto CC: , , , , , Subject: Re: [PATCH v1 1/1] ASoC: rsnd: ssi: Fix issue in dma data address assignment References: <1513832314-29727-1-git-send-email-jiada_wang@mentor.com> <87k1xgbnfz.wl%kuninori.morimoto.gx@renesas.com> <5A3B5EFE.8070606@mentor.com> <87ind0bkte.wl%kuninori.morimoto.gx@renesas.com> <5A3B7BF7.7060400@mentor.com> <87d137ob24.wl%kuninori.morimoto.gx@renesas.com> In-Reply-To: <87d137ob24.wl%kuninori.morimoto.gx@renesas.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SVR-ORW-MBX-06.mgc.mentorg.com (147.34.90.206) To svr-orw-mbx-03.mgc.mentorg.com (147.34.90.203) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Morimoto-san On 12/21/2017 04:43 PM, Kuninori Morimoto wrote: > Hi Jiada > > Thank you for your feedback > I understand your situation > >> We have enabled TDM Split and Ex-Split mode in our kernel, >> and SSI(U)'s dma address diffs based on the BUSIF it is using, >> so have a single dma data struct per rsnd_ssi will cause issue when >> SSI isn't working with BUSIF0. > First of all, "TDM (Ex) Split mode" is not yet supported. > And unfortunately, your patch is not enough for it. > I guess you enabled it with many local patches, > and posted one of them ? > > It is very advanced feature, we need to consider about > channel/sampling rate/data width/settings/address etc etc etc... > Lots of things we need to solve/care ! > DMA pointer is one of them. > > If we focus only to DMA, your patch is still wrong I think. > "Playback/Capture direction" is not related to this topic. > 1 DMA on 1 DAI is enough ? > And we need to update rsnd_gen2_dma_addr() too for DMA address. Yes, this patch is only one of a serial patch set to enable TDM (Ex) Split mode, I submitted it alone because think it is independent, but you are right, to make the background more clear, I will submit the whole patch set together with this single patch in v2, (this probably will take some time) Thanks, Jiada >> Do you have any suggestion to address this issue? > I have no idea at this point. > Missing part for TDM (Ex) Split mode is not only DMA pointer. > > Why do you want to use it ? > If you want to do is only "use 2 DAIs for playback", > how about to use MIXer ? It is already supported on upstream. > Best regards > --- > Kuninori Morimoto