From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932089AbeAOFf5 (ORCPT + 1 other); Mon, 15 Jan 2018 00:35:57 -0500 Received: from mailout4.samsung.com ([203.254.224.34]:21420 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751199AbeAOFfz (ORCPT ); Mon, 15 Jan 2018 00:35:55 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 mailout4.samsung.com 20180115053553epoutp047e2a8d1669906ae904cac157c422da40~J5QOX2_rC0431704317epoutp042 X-AuditID: b6c32a37-413ff70000001041-10-5a5c3db16fe6 MIME-version: 1.0 Content-transfer-encoding: 8BIT Content-type: text/plain; charset="UTF-8" Message-id: <5A5C3DB1.5080604@samsung.com> Date: Mon, 15 Jan 2018 14:35:45 +0900 From: Chanwoo Choi Organization: Samsung Electronics User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Hans de Goede , MyungJoo Ham , Chen-Yu Tsai Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] extcon: axp288: Constify the axp288_pwr_up_down_info array In-reply-to: <20180114151021.11432-1-hdegoede@redhat.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrGKsWRmVeSWpSXmKPExsWy7bCmge5G25gog1cNhhZvjk9nsri8aw6b xe3GFWwWPw+dZ3Jg8djwaDWrx/t9V9k8+rasYvT4vEkugCUq1SYjNTEltUghNS85PyUzL91W yTs43jne1MzAUNfQ0sJcSSEvMTfVVsnFJ0DXLTMHaKWSQlliTilQKCCxuFhJ386mKL+0JFUh I7+4xFYp2tDQSM/QwFzPyMhIz8Q41srIFKgkITVjXfMm1oIJ3BWHPjQyNTC+5uhi5OSQEDCR WLK+m7GLkYtDSGAHo8SzKdPZIJzvQM7/d4wwVU8n/WaHSGxglLjecIMVJMErICjxY/I9li5G Dg5mAXmJI5eyQcLMApoSW3evh6q/xyjx78AzZpAaXgEtib0HkkFqWARUJQ69fMUEYrMBhfe/ uMEGYvMLKEpc/fEYbK+oQITEzvnf2EFsEYECicYf29gg5itI/Lq3CewEYYFQibaWl2A1nAKW EhOmNrOC7JUQ2MAm0Xf6FNQDLhJdz5azQdjCEq+Ob2EHuUdCQFri0lFbiPp2Ron2vfOYIZwp jBLnrt9jgmgwlni2sIsJYjOfxLuvPawQzbwSHW1CECUeErPvgDwDEnaUWH0nC+L3HkaJiX82 sE5glJuFFFyzEME1Cym4FjAyr2IUSy0ozk1PLTYsMNYrTswtLs1L10vOz93ECE5jWuY7GDec 8znEKMDBqMTDy7AkOkqINbGsuDL3EKMEB7OSCG/Y6YgoId6UxMqq1KL8+KLSnNTiQ4ymwOCe yCwlmpwPTLF5JfGGJpYGJmZGwNRlaWioJM4bEOASJSSQnliSmp2aWpBaBNPHxMEp1cA4O/ta rHAp61ytWflP/uodYrpv8ZNj1vP8431TJzE/+uWYuPZo27q0imPS/+oP/D/1UmLJ5bvfD235 6bp+z+b1kRdk/nVHXYnsvPprdw+L5FSRedMnlP079WzKFbcTGu9edai9WHmLK7p+TspJ46RT 31LdTvOWmBi7MrDyLFpzP0RL6ICc2IlPlUosxRmJhlrMRcWJALN9xfh5AwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrBLMWRmVeSWpSXmKPExsVy+t9jQd2NtjFRBj9+i1q8OT6dyeLyrjls FrcbV7BZ/Dx0nsmBxWPDo9WsHu/3XWXz6NuyitHj8ya5AJYoLpuU1JzMstQifbsErox1zZtY CyZwVxz60MjUwPiao4uRk0NCwETi6aTf7F2MXBxCAusYJT68nscGkuAVEJT4MfkeSxcjBwez gLzEkUvZIGFmAXWJSfMWMUPUP2CUeDR3CSNIDa+AlsTeA8kgNSwCqhKHXr5iArHZgML7X9wA G8kvoChx9cdjsHJRgQiJ7hOVIKaIQIFE37dKiOkKEr/ubWIFsYUFQiVmnYe5rI9R4tz3I2AJ TgFLiQlTm1knMArMQnLoLIRDZyE5dAEj8ypGydSC4tz03GKjAsO81HK94sTc4tK8dL3k/NxN jMDw3XZYq28H4/0l8YcYBTgYlXh4I5ZFRwmxJpYVV+YeYpTgYFYS4Q07HRElxJuSWFmVWpQf X1Sak1p8iFGag0VJnPd23rFIIYH0xJLU7NTUgtQimCwTB6dUA2PqnpRiMYnjoszJYrLTm3LO KXy77tT++9Ca7peLb7RcTzoVMN9CWVSTY9NO8cULvxQvf/jvl+4vyehXIp/Vpr6v/tAasrzu 7uHEKxzfrXpfn10vem8Gs/eJuzMXvK3i/LLkz6pav0C/yw0/4+KZlxowPWHr5P51eLL3nj0z Bd/Xy39bU5A2TzZDiaU4I9FQi7moOBEA2yW7fFsCAAA= X-CMS-MailID: 20180115053545epcas1p4bb586e30c49db43725f7afdbb5a0371f X-Msg-Generator: CA CMS-TYPE: 101P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20180114151033epcas4p4f32a575853ca8d34d2eb362ba7d8b197 X-RootMTR: 20180114151033epcas4p4f32a575853ca8d34d2eb362ba7d8b197 References: <20180114151021.11432-1-hdegoede@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On 2018년 01월 15일 00:10, Hans de Goede wrote: > Make the axp288_pwr_up_down_info array const char * const, this leads > to the following section size changes: > > .text 0x674 -> 0x664 > .data 0x148 -> 0x0f0 > .rodata 0x0b4 -> 0x114 > > Signed-off-by: Hans de Goede > --- > drivers/extcon/extcon-axp288.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/extcon/extcon-axp288.c b/drivers/extcon/extcon-axp288.c > index 081d8a1b4fd7..63b99d5becd7 100644 > --- a/drivers/extcon/extcon-axp288.c > +++ b/drivers/extcon/extcon-axp288.c > @@ -118,7 +118,7 @@ static const struct x86_cpu_id cherry_trail_cpu_ids[] = { > }; > > /* Power up/down reason string array */ > -static char *axp288_pwr_up_down_info[] = { > +static const char * const axp288_pwr_up_down_info[] = { > "Last wake caused by user pressing the power button", > "Last wake caused by a charger insertion", > "Last wake caused by a battery insertion", > @@ -136,7 +136,7 @@ static char *axp288_pwr_up_down_info[] = { > */ > static void axp288_extcon_log_rsi(struct axp288_extcon_info *info) > { > - char **rsi; > + const char * const *rsi; > unsigned int val, i, clear_mask = 0; > int ret; > > Applied it to v4.17 because I had finished the extcon pull request for v4.16. -- Best Regards, Chanwoo Choi Samsung Electronics