public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: JeffyChen <jeffy.chen@rock-chips.com>
To: Tomasz Figa <tfiga@chromium.org>
Cc: linux-kernel@vger.kernel.org, Ricky Liang <jcliang@chromium.org>,
	Robin Murphy <robin.murphy@arm.com>,
	simon xue <xxm@rock-chips.com>, Heiko Stuebner <heiko@sntech.de>,
	"open list:ARM/Rockchip SoC..."
	<linux-rockchip@lists.infradead.org>,
	"list@263.net:IOMMU DRIVERS" <iommu@lists.linux-foundation.org>,
	Joerg Roedel <joro@8bytes.org>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 11/13] iommu/rockchip: Use OF_IOMMU to attach devices automatically
Date: Wed, 17 Jan 2018 15:47:47 +0800	[thread overview]
Message-ID: <5A5EFFA3.6070206@rock-chips.com> (raw)
In-Reply-To: <CAAFQd5AOZ797dNEvr5TbuWK-rw=dTCArUZM53t4_gNRugBd=sg@mail.gmail.com>

On 01/17/2018 03:30 PM, Tomasz Figa wrote:
>> >but it's possible the probe failed after calling iommu_device_set_fwnode, so
>> >i'll try to add some checks here, and maybe adjust probe() to prevent it
>> >too.
> I think iommu_device_set_fwnode() is not enough for of_iommu_xlate()
> to find the IOMMU. The IOMMU is actually added to the IOMMU list by
> iommu_device_register(), which is last in the sequence, so I guess we
> should be fine.
>
hmmm, the later patch would change that ;) i'll fix it in the next version.

> Best regards,
> Tomasz
>
>
>

  reply	other threads:[~2018-01-17  7:48 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-16 13:25 [PATCH v2 00/13] iommu/rockchip: Use OF_IOMMU Jeffy Chen
2018-01-16 13:25 ` [PATCH v2 01/13] iommu/rockchip: Request irqs in rk_iommu_probe() Jeffy Chen
2018-01-17  4:21   ` Tomasz Figa
     [not found]     ` <5A5EF672.6040304@rock-chips.com>
2018-01-17  7:16       ` Tomasz Figa
2018-01-17  7:45         ` JeffyChen
2018-01-17 12:18   ` Robin Murphy
2018-01-17 12:46     ` JeffyChen
2018-01-16 13:25 ` [PATCH v2 02/13] iommu/rockchip: Suppress unbinding Jeffy Chen
2018-01-17  4:23   ` Tomasz Figa
2018-01-17  5:32     ` Tomasz Figa
2018-01-16 13:25 ` [PATCH v2 03/13] iommu/rockchip: Fix error handling in attach Jeffy Chen
2018-01-16 13:25 ` [PATCH v2 04/13] iommu/rockchip: Fix error handling in probe Jeffy Chen
2018-01-17  5:22   ` Tomasz Figa
2018-01-16 13:25 ` [PATCH v2 05/13] iommu/rockchip: Fix error handling in init Jeffy Chen
2018-01-17  5:26   ` Tomasz Figa
     [not found]     ` <5A5EF7D3.90405@rock-chips.com>
2018-01-17  7:19       ` Tomasz Figa
2018-01-17 12:27         ` Tomasz Figa
2018-01-17 11:36     ` Robin Murphy
2018-01-16 13:25 ` [PATCH v2 06/13] iommu/rockchip: Use iopoll helpers to wait for hardware Jeffy Chen
2018-01-16 13:25 ` [PATCH v2 07/13] iommu/rockchip: Fix TLB flush of secondary IOMMUs Jeffy Chen
2018-01-16 13:25 ` [PATCH v2 08/13] iommu/rockchip: Control clocks needed to access the IOMMU Jeffy Chen
2018-01-16 13:25 ` [PATCH v2 09/13] iommu/rockchip: Use iommu_group_get_for_dev() for add_device Jeffy Chen
2018-01-17 12:31   ` Robin Murphy
2018-01-17 12:47     ` JeffyChen
2018-01-17 12:53       ` JeffyChen
2018-01-16 13:25 ` [PATCH v2 10/13] iommu/rockchip: Use IOMMU device for dma mapping operations Jeffy Chen
2018-01-17  5:37   ` Tomasz Figa
2018-01-16 13:25 ` [PATCH v2 11/13] iommu/rockchip: Use OF_IOMMU to attach devices automatically Jeffy Chen
2018-01-17  5:44   ` Tomasz Figa
     [not found]     ` <5A5EF94E.7010806@rock-chips.com>
2018-01-17  7:30       ` Tomasz Figa
2018-01-17  7:47         ` JeffyChen [this message]
2018-01-16 13:25 ` [PATCH v2 12/13] iommu/rockchip: Add runtime PM support Jeffy Chen
2018-01-17  6:20   ` Tomasz Figa
     [not found]     ` <5A5EFAB2.7040001@rock-chips.com>
2018-01-17  7:38       ` Tomasz Figa
2018-01-17  7:52         ` JeffyChen
2018-01-17  8:48           ` JeffyChen
2018-01-16 13:25 ` [PATCH v2 13/13] iommu/rockchip: Support sharing IOMMU between masters Jeffy Chen
2018-01-17 13:00   ` Robin Murphy
2018-01-17 13:32     ` JeffyChen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5A5EFFA3.6070206@rock-chips.com \
    --to=jeffy.chen@rock-chips.com \
    --cc=heiko@sntech.de \
    --cc=iommu@lists.linux-foundation.org \
    --cc=jcliang@chromium.org \
    --cc=joro@8bytes.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=robin.murphy@arm.com \
    --cc=tfiga@chromium.org \
    --cc=xxm@rock-chips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox