From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AH8x224cgQm5+u6aPfdlX35cazqdpaSvjLTROTExN8UUIMR9E9yp0bUIQruh+gFlN68rtBJHy25O ARC-Seal: i=1; a=rsa-sha256; t=1516781820; cv=none; d=google.com; s=arc-20160816; b=wJLLDewnQ1o1URbsSGCtcBAfsGCqLdeWqjB7Jp5P5mUzlTfYsOqFwQhkLV2nvJE5qP GC63ztH5/Tf2DBsmaayU/9e4nQBm/Lvgvjv86gB3o3nn6gsdF6m8IEoPsoXtE/CYEMFC D7XuIBSLvIRCqP3R7mDdCaLGOzlC/oQuz5zY8Wi8dGZDF2gMQqm1qZDGVSN+PIXvaaxB WFvxjbyoKkcMIIE/G70VPN668fRnnggLUA1wupQYHbgO+1HtsE8yROH81hFW6oC8FOLM JMYTkrcohyWNDfi/JUNePzd1UjMZ5p41QOzivmI5aq1ErI6R6vrIYBUUBB+dBax3cVcx fmIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:references:subject:cc:to :mime-version:user-agent:reply-to:from:date:message-id :arc-authentication-results; bh=nZtgq4BRDOtE8GxluJ5woddyIvruJlyEghuZ7I6OSz0=; b=Rfhle5X9HBGYqjQrRHrWLUbYENgnqY657ZVHEXd92x8q/PrYcUeUdFhH82rHey0ql4 Vmo/uwygaI3l97coAhUa1LVZXpxhA8mufijjEOtbhym8ZX462JLY4lEyu/OGesgPtBUp 4PJ8MG6+n6xYJt4FaLySdhv8Uqtv4DB2haeYU7V4bQJUepQ5Ms4To3bTKYDxn/HDvuaR 9SSHweSTqb6+hJ49D6jLE2w+KTf+sjRI86wN1mwDp4OgLe7MlfOWeAFunvXsBN6lqCqT UFHysDgrRzefOLuG5XWR+6ag+jTDwpuNR7e0r4qmS4uakWCqleVabiJ0iA3b+yHFREuk cSCA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of wharms@bfs.de designates 193.174.231.67 as permitted sender) smtp.mailfrom=wharms@bfs.de Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of wharms@bfs.de designates 193.174.231.67 as permitted sender) smtp.mailfrom=wharms@bfs.de Message-ID: <5A6840F0.9090201@bfs.de> Date: Wed, 24 Jan 2018 09:16:48 +0100 From: walter harms Reply-To: wharms@bfs.de User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; de; rv:1.9.1.16) Gecko/20101125 SUSE/3.0.11 Thunderbird/3.0.11 MIME-Version: 1.0 To: kernel-janitors@vger.kernel.org CC: =?UTF-8?B?Q2hyaXN0b3BoZXIgRMOtYXogUml2ZXJvcw==?= , sudeep.dutt@intel.com, ashutosh.dixit@intel.com, arnd@arndb.de, gregkh@linuxfoundation.org, viro@zeniv.linux.org.uk, linux-kernel@vger.kernel.org Subject: Re: [PATCH-next] misc: mic: Use PTR_ERR_OR_ZERO References: <20180123201009.12998-1-chrisadr@gentoo.org> In-Reply-To: <20180123201009.12998-1-chrisadr@gentoo.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1590415328315757561?= X-GMAIL-MSGID: =?utf-8?q?1590461014169659675?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: Am 23.01.2018 21:10, schrieb Christopher Díaz Riveros: > Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Christopher Díaz Riveros > --- > drivers/misc/mic/scif/scif_epd.h | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/misc/mic/scif/scif_epd.h b/drivers/misc/mic/scif/scif_epd.h > index f39b663da287..b2a835665390 100644 > --- a/drivers/misc/mic/scif/scif_epd.h > +++ b/drivers/misc/mic/scif/scif_epd.h > @@ -165,9 +165,7 @@ static inline int scif_verify_epd(struct scif_endpt *ep) > static inline int scif_anon_inode_getfile(scif_epd_t epd) > { > epd->anon = anon_inode_getfile("scif", &scif_anon_fops, NULL, 0); > - if (IS_ERR(epd->anon)) > - return PTR_ERR(epd->anon); > - return 0; > + return PTR_ERR_OR_ZERO(epd->anon); > } > the patch looks ok, but someone should thing about if it makes sense to have a oneliner as function. IMHO this will only confuse readers (note: yes, there are reasons in some cases, but i do not see what applies here if any). re, wh > static inline void scif_anon_inode_fput(scif_epd_t epd)