From: Inki Dae <inki.dae@samsung.com>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>,
linux-kernel@vger.kernel.org
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
linux-renesas-soc@vger.kernel.org,
Joonyoung Shim <jy0922.shim@samsung.com>,
Seung-Woo Kim <sw0312.kim@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
David Airlie <airlied@linux.ie>, Kukjin Kim <kgene@kernel.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH 2/4] drm/exynos: fix comparison to bitshift when dealing with a mask
Date: Tue, 06 Feb 2018 09:06:21 +0900 [thread overview]
Message-ID: <5A78F17D.1010400@samsung.com> (raw)
In-Reply-To: <20180205201002.23621-3-wsa+renesas@sang-engineering.com>
2018년 02월 06일 05:09에 Wolfram Sang 이(가) 쓴 글:
> Due to a typo, the mask was destroyed by a comparison instead of a bit
> shift.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
> Only build tested. To be applied individually per subsystem.
>
> drivers/gpu/drm/exynos/regs-fimc.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/exynos/regs-fimc.h b/drivers/gpu/drm/exynos/regs-fimc.h
> index 30496134a3d072..d7cbe53c4c01f4 100644
> --- a/drivers/gpu/drm/exynos/regs-fimc.h
> +++ b/drivers/gpu/drm/exynos/regs-fimc.h
> @@ -569,7 +569,7 @@
> #define EXYNOS_CIIMGEFF_FIN_EMBOSSING (4 << 26)
> #define EXYNOS_CIIMGEFF_FIN_SILHOUETTE (5 << 26)
> #define EXYNOS_CIIMGEFF_FIN_MASK (7 << 26)
> -#define EXYNOS_CIIMGEFF_PAT_CBCR_MASK ((0xff < 13) | (0xff < 0))
> +#define EXYNOS_CIIMGEFF_PAT_CBCR_MASK ((0xff << 13) | (0xff << 0))
>
Oops. Picked it up.
Thanks,
Inki Dae
> /* Real input DMA size register */
> #define EXYNOS_CIREAL_ISIZE_AUTOLOAD_ENABLE (1 << 31)
>
next prev parent reply other threads:[~2018-02-06 0:06 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-05 20:09 [PATCH 0/4] tree-wide: fix comparison to bitshift when dealing with a mask Wolfram Sang
2018-02-05 20:09 ` [PATCH 1/4] v4l: vsp1: fix mask creation for MULT_ALPHA_RATIO Wolfram Sang
2018-02-22 16:07 ` Laurent Pinchart
2018-02-05 20:09 ` [PATCH 2/4] drm/exynos: fix comparison to bitshift when dealing with a mask Wolfram Sang
2018-02-06 0:06 ` Inki Dae [this message]
2018-02-05 20:10 ` [PATCH 3/4] v4l: dvb-frontends: stb0899: " Wolfram Sang
2018-02-05 20:10 ` [PATCH 4/4] net: amd-xgbe: " Wolfram Sang
2018-02-05 22:35 ` Tom Lendacky
2018-02-06 16:25 ` David Miller
2018-02-06 8:20 ` [PATCH 0/4] tree-wide: " Geert Uytterhoeven
2018-02-06 8:28 ` Wolfram Sang
2018-02-06 13:10 ` Dan Carpenter
2018-02-06 13:15 ` Julia Lawall
2018-02-06 13:23 ` Dan Carpenter
2018-02-06 13:40 ` Julia Lawall
2018-02-06 13:53 ` Wolfram Sang
2018-02-06 13:54 ` Julia Lawall
2018-02-06 13:57 ` Wolfram Sang
2018-02-06 13:59 ` Dan Carpenter
2018-02-06 14:08 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5A78F17D.1010400@samsung.com \
--to=inki.dae@samsung.com \
--cc=airlied@linux.ie \
--cc=dan.carpenter@oracle.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jy0922.shim@samsung.com \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=sw0312.kim@samsung.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox