From: Chanwoo Choi <cw00.choi@samsung.com>
To: Hans de Goede <hdegoede@redhat.com>,
MyungJoo Ham <myungjoo.ham@samsung.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/3] Revert "extcon: axp288: Redo charger type detection a couple of seconds after probe()"
Date: Tue, 13 Feb 2018 06:50:29 +0900 [thread overview]
Message-ID: <5A820C25.1050701@samsung.com> (raw)
In-Reply-To: <20180212194630.7216-2-hdegoede@redhat.com>
On 2018년 02월 13일 04:46, Hans de Goede wrote:
> Redoing the charger type detection to give the usb-role-switch code time
> to properly set the role-switch is no good for mainline, since the
> usb-role-switch code is not yet in mainline (my bad, sorry).
>
> Also once we've that code there are better ways to fix this which are
> not prone to racing as doing a retry after 2 seconds is.
>
> This reverts commit 50082c17bb1455acacd376ae30dff92f2e1addbd.
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
> drivers/extcon/extcon-axp288.c | 32 ++------------------------------
> 1 file changed, 2 insertions(+), 30 deletions(-)
Applied it.
[snip]
--
Best Regards,
Chanwoo Choi
Samsung Electronics
next prev parent reply other threads:[~2018-02-12 21:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20180212194646epcas3p4de9a5b929ea45edb11f7e5b509b6cf98@epcas3p4.samsung.com>
2018-02-12 19:46 ` [PATCH v3 1/3] extcon: axp288: Constify the axp288_pwr_up_down_info array Hans de Goede
2018-02-12 19:46 ` [PATCH v3 2/3] Revert "extcon: axp288: Redo charger type detection a couple of seconds after probe()" Hans de Goede
2018-02-12 21:50 ` Chanwoo Choi [this message]
2018-02-12 19:46 ` [PATCH v3 3/3] extcon: int3496: process id-pin first so that we start with the right status Hans de Goede
2018-02-12 21:50 ` Chanwoo Choi
2018-02-12 21:50 ` [PATCH v3 1/3] extcon: axp288: Constify the axp288_pwr_up_down_info array Chanwoo Choi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5A820C25.1050701@samsung.com \
--to=cw00.choi@samsung.com \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).