public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: piaojun <piaojun@huawei.com>
To: Larry Chen <lchen@suse.com>, <mfasheh@versity.com>, <jlbec@evilplan.org>
Cc: <linux-kernel@vger.kernel.org>, <ocfs2-devel@oss.oracle.com>
Subject: Re: [Ocfs2-devel] [PATCH] Correct a comment error
Date: Thu, 1 Mar 2018 20:56:46 +0800	[thread overview]
Message-ID: <5A97F88E.4010303@huawei.com> (raw)
In-Reply-To: <20180228101720.20725-1-lchen@suse.com>

Hi Larry,

There is the same mistake in ocfs2_reflink_inodes_lock(), could you help
fixing them all?

thanks,
Jun

On 2018/2/28 18:17, Larry Chen wrote:
> The function ocfs2_double_lock tries to lock the inode with lower
> blockid first, not lockid.
> 
> Signed-off-by: Larry Chen <lchen@suse.com>
> ---
>  fs/ocfs2/namei.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/ocfs2/namei.c b/fs/ocfs2/namei.c
> index c801eddc4bf3..30d454de35a8 100644
> --- a/fs/ocfs2/namei.c
> +++ b/fs/ocfs2/namei.c
> @@ -1133,7 +1133,7 @@ static int ocfs2_double_lock(struct ocfs2_super *osb,
>  	if (*bh2)
>  		*bh2 = NULL;
>  
> -	/* we always want to lock the one with the lower lockid first.
> +	/* we always want to lock the one with the lower blockid first.
>  	 * and if they are nested, we lock ancestor first */
>  	if (oi1->ip_blkno != oi2->ip_blkno) {
>  		inode1_is_ancestor = ocfs2_check_if_ancestor(osb, oi2->ip_blkno,
> 

  parent reply	other threads:[~2018-03-01 13:05 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20180228101720.20725-1-lchen@suse.com>
2018-03-01  0:36 ` [Ocfs2-devel] [PATCH] Correct a comment error Changwei Ge
2018-03-01 12:56 ` piaojun [this message]
2018-03-02  1:59   ` Changwei Ge
2018-03-02  2:15     ` piaojun
2018-03-02  2:37       ` Larry Chen
2018-03-02  2:38       ` Changwei Ge

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5A97F88E.4010303@huawei.com \
    --to=piaojun@huawei.com \
    --cc=jlbec@evilplan.org \
    --cc=lchen@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mfasheh@versity.com \
    --cc=ocfs2-devel@oss.oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox