* Re: [PATCH] arm64: defconfig: Enable typec-phy and extcon-usbc-cros-ec for rk3399
2018-02-28 14:02 ` [PATCH] arm64: defconfig: Enable typec-phy and extcon-usbc-cros-ec for rk3399 Enric Balletbo i Serra
@ 2018-03-01 2:19 ` Alexandre Courbot
2018-03-01 23:42 ` Chanwoo Choi
1 sibling, 0 replies; 3+ messages in thread
From: Alexandre Courbot @ 2018-03-01 2:19 UTC (permalink / raw)
To: Enric Balletbo i Serra
Cc: Catalin Marinas, Will Deacon, linux-arm-kernel, LKML, kernel
On Wed, Feb 28, 2018 at 11:02 PM, Enric Balletbo i Serra
<enric.balletbo@collabora.com> wrote:
> Enables typec phyter and extcon driver for cable detection that is used by
> USB 3.0 controller for Rockchip rk3399 SoCs.
>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Tested-by: Alexandre Courbot <acourbot@chromium.org>
Thanks! This fixes a USB regression in 4.16-rc1 and -rc2 for
gru-kevin. Neither USB3 nor USB2 were usable whereas at least USB2 was
usable in 4.15.
> ---
> arch/arm64/configs/defconfig | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index 78b47bc7dc54..d4c25aa55785 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -544,6 +544,7 @@ CONFIG_ARCH_TEGRA_132_SOC=y
> CONFIG_ARCH_TEGRA_210_SOC=y
> CONFIG_ARCH_TEGRA_186_SOC=y
> CONFIG_EXTCON_USB_GPIO=y
> +CONFIG_EXTCON_USBC_CROS_EC=y
> CONFIG_IIO=y
> CONFIG_EXYNOS_ADC=y
> CONFIG_ROCKCHIP_SARADC=m
> @@ -564,6 +565,7 @@ CONFIG_PHY_MVEBU_CP110_COMPHY=y
> CONFIG_PHY_ROCKCHIP_INNO_USB2=y
> CONFIG_PHY_ROCKCHIP_EMMC=y
> CONFIG_PHY_ROCKCHIP_PCIE=m
> +CONFIG_PHY_ROCKCHIP_TYPEC=y
> CONFIG_PHY_XGENE=y
> CONFIG_PHY_TEGRA_XUSB=y
> CONFIG_QCOM_L2_PMU=y
> --
> 2.16.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: defconfig: Enable typec-phy and extcon-usbc-cros-ec for rk3399
2018-02-28 14:02 ` [PATCH] arm64: defconfig: Enable typec-phy and extcon-usbc-cros-ec for rk3399 Enric Balletbo i Serra
2018-03-01 2:19 ` Alexandre Courbot
@ 2018-03-01 23:42 ` Chanwoo Choi
1 sibling, 0 replies; 3+ messages in thread
From: Chanwoo Choi @ 2018-03-01 23:42 UTC (permalink / raw)
To: Enric Balletbo i Serra, Catalin Marinas, Will Deacon
Cc: linux-arm-kernel, linux-kernel, acourbot, kernel
On 2018년 02월 28일 23:02, Enric Balletbo i Serra wrote:
> Enables typec phyter and extcon driver for cable detection that is used by
> USB 3.0 controller for Rockchip rk3399 SoCs.
>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> ---
> arch/arm64/configs/defconfig | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index 78b47bc7dc54..d4c25aa55785 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -544,6 +544,7 @@ CONFIG_ARCH_TEGRA_132_SOC=y
> CONFIG_ARCH_TEGRA_210_SOC=y
> CONFIG_ARCH_TEGRA_186_SOC=y
> CONFIG_EXTCON_USB_GPIO=y
> +CONFIG_EXTCON_USBC_CROS_EC=y
> CONFIG_IIO=y
> CONFIG_EXYNOS_ADC=y
> CONFIG_ROCKCHIP_SARADC=m
> @@ -564,6 +565,7 @@ CONFIG_PHY_MVEBU_CP110_COMPHY=y
> CONFIG_PHY_ROCKCHIP_INNO_USB2=y
> CONFIG_PHY_ROCKCHIP_EMMC=y
> CONFIG_PHY_ROCKCHIP_PCIE=m
> +CONFIG_PHY_ROCKCHIP_TYPEC=y
> CONFIG_PHY_XGENE=y
> CONFIG_PHY_TEGRA_XUSB=y
> CONFIG_QCOM_L2_PMU=y
>
Looks good to me.
Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
--
Best Regards,
Chanwoo Choi
Samsung Electronics
^ permalink raw reply [flat|nested] 3+ messages in thread