From: JeffyChen <jeffy.chen@rock-chips.com>
To: Brian Norris <briannorris@chromium.org>
Cc: linux-kernel@vger.kernel.org, briannorris@google.com,
dtor@google.com, dianders@google.com,
Enric Balletbo i Serra <enric.balletbo@collabora.com>,
Thomas Gleixner <tglx@linutronix.de>,
Joseph Lo <josephl@nvidia.com>, stephen lu <lumotuwe@gmail.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Kate Stewart <kstewart@linuxfoundation.org>,
linux-input@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Philippe Ombredanne <pombredanne@nexb.com>,
Arvind Yadav <arvind.yadav.cs@gmail.com>
Subject: Re: [PATCH v2 1/3] Input: gpio-keys - add support for wakeup event action
Date: Fri, 02 Mar 2018 11:57:21 +0800 [thread overview]
Message-ID: <5A98CBA1.6090801@rock-chips.com> (raw)
In-Reply-To: <20180302023229.GA164361@rodete-desktop-imager.corp.google.com>
Hi Brain,
Thanks for your reply.
On 03/02/2018 10:32 AM, Brian Norris wrote:
>>> > >What about the 'else' case? Shouldn't we try to handle that?
>> >i think the else case is for irq key, which would generate down and up
>> >events in one irq, so it would use the same trigger type for all these 3
>> >cases.
> Not necessarily. It uses whatever trigger was provided in
> platform/DT/etc. data. You could retrieve that with
> irq_get_trigger_type() and try to interpret that. Or you could just
> outlaw using that combination (e.g., in the binding documentation).
i think for the IRQ button case the assert/deassert/any are using the
same irq trigger type, so it should be ok to leave the wakeup trigger
type to be 0(not reconfigure the trigger type)...
i've made a v3 to add a comment about that, but forgot to send it :(
>
> Brian
>
next prev parent reply other threads:[~2018-03-02 3:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-10 11:09 [PATCH v2 0/3] gpio-keys: Add support for specifying wakeup event action Jeffy Chen
2018-02-10 11:09 ` [PATCH v2 1/3] Input: gpio-keys - add support for " Jeffy Chen
2018-02-12 22:13 ` Brian Norris
2018-02-13 10:40 ` Enric Balletbo i Serra
2018-02-13 18:25 ` Brian Norris
2018-02-13 22:25 ` Enric Balletbo Serra
2018-02-23 10:15 ` JeffyChen
2018-02-23 10:04 ` JeffyChen
2018-03-02 2:32 ` Brian Norris
2018-03-02 3:57 ` JeffyChen [this message]
2018-02-10 11:09 ` [PATCH v2 2/3] Input: gpio-keys - allow setting wakeup event action in DT Jeffy Chen
2018-03-01 21:26 ` Rob Herring
2018-02-10 11:09 ` [PATCH v2 3/3] arm64: dts: rockchip: Avoid wakeup when inserting the pen Jeffy Chen
2018-02-14 13:39 ` [PATCH v2 0/3] gpio-keys: Add support for specifying wakeup event action Heiko Stübner
2018-02-23 9:43 ` JeffyChen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5A98CBA1.6090801@rock-chips.com \
--to=jeffy.chen@rock-chips.com \
--cc=arvind.yadav.cs@gmail.com \
--cc=briannorris@chromium.org \
--cc=briannorris@google.com \
--cc=dianders@google.com \
--cc=dmitry.torokhov@gmail.com \
--cc=dtor@google.com \
--cc=enric.balletbo@collabora.com \
--cc=gregkh@linuxfoundation.org \
--cc=josephl@nvidia.com \
--cc=kstewart@linuxfoundation.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lumotuwe@gmail.com \
--cc=pombredanne@nexb.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox