From: Wei Xu <xuwei5@hisilicon.com>
To: Viresh Kumar <viresh.kumar@linaro.org>,
Rafael Wysocki <rjw@rjwysocki.net>
Cc: <linux-pm@vger.kernel.org>,
Vincent Guittot <vincent.guittot@linaro.org>,
Eduardo Valentin <edubezval@gmail.com>,
Mark Rutland <mark.rutland@arm.com>,
Rob Herring <robh+dt@kernel.org>, Zhang Rui <rui.zhang@intel.com>,
<linux-arm-kernel@lists.infradead.org>,
<devicetree@vger.kernel.org>, <daniel.lezcano@linaro.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 05/10] ARM64: dts: hi6220: Remove "cooling-{min|max}-level" for CPU nodes
Date: Fri, 2 Mar 2018 16:03:54 +0000 [thread overview]
Message-ID: <5A9975EA.3010306@hisilicon.com> (raw)
In-Reply-To: <68740229a7397336ae92bad65f69a58c91819c37.1518166039.git.viresh.kumar@linaro.org>
Hi Viresh,
On 2018/2/9 8:58, Viresh Kumar wrote:
> The "cooling-min-level" and "cooling-max-level" properties are not
> parsed by any part of the kernel currently and the max cooling state of
> a CPU cooling device is found by referring to the cpufreq table instead.
>
> Moreover, the entries are incorrect here as min level is 4 and the max
> level is 0.
>
> Remove the unused properties from the CPU nodes.
>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
Applied into hisilicon dt tree.
Thanks!
BR,
Wei
> arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
> index 6a180d1926e8..fca8e4ee98e7 100644
> --- a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
> +++ b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
> @@ -88,8 +88,6 @@
> next-level-cache = <&CLUSTER0_L2>;
> clocks = <&stub_clock 0>;
> operating-points-v2 = <&cpu_opp_table>;
> - cooling-min-level = <4>;
> - cooling-max-level = <0>;
> #cooling-cells = <2>; /* min followed by max */
> cpu-idle-states = <&CPU_SLEEP &CLUSTER_SLEEP>;
> dynamic-power-coefficient = <311>;
>
next prev parent reply other threads:[~2018-03-02 16:04 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-09 8:58 [PATCH 00/10] thermal: Remove "cooling-{min|max}-level" properties Viresh Kumar
2018-02-09 8:58 ` [PATCH 01/10] ARM: dts: exynos: Remove "cooling-{min|max}-level" for CPU nodes Viresh Kumar
2018-02-13 18:16 ` Krzysztof Kozlowski
2018-02-09 8:58 ` [PATCH 02/10] ARM: dts: omap: " Viresh Kumar
2018-02-12 17:17 ` Tony Lindgren
2018-02-12 17:18 ` Tony Lindgren
2018-02-09 8:58 ` [PATCH 03/10] ARM: dts: mt7623: " Viresh Kumar
2018-02-18 23:26 ` Rob Herring
2018-02-09 8:58 ` [PATCH 04/10] ARM: dts: sun[4-7]i: " Viresh Kumar
2018-02-13 9:13 ` Maxime Ripard
2018-02-13 9:18 ` Chen-Yu Tsai
2018-02-14 3:12 ` Viresh Kumar
2018-02-09 8:58 ` [PATCH 05/10] ARM64: dts: hi6220: " Viresh Kumar
2018-03-02 16:03 ` Wei Xu [this message]
2018-02-09 8:58 ` [PATCH 06/10] ARM64: dts: meson: " Viresh Kumar
2018-02-09 9:03 ` Neil Armstrong
2018-03-12 4:32 ` Viresh Kumar
2018-03-20 1:37 ` Viresh Kumar
2018-03-27 12:29 ` Arnd Bergmann
2018-02-09 8:58 ` [PATCH 07/10] ARM: dts: gemini: Remove "cooling-{min|max}-level" for gpio-fan node Viresh Kumar
2018-03-12 4:35 ` Viresh Kumar
2018-03-20 1:43 ` Viresh Kumar
2018-03-20 3:10 ` Linus Walleij
2018-03-27 12:26 ` Arnd Bergmann
2018-03-27 12:29 ` Linus Walleij
2018-02-09 8:58 ` [PATCH 08/10] ARM64: dts: meson: " Viresh Kumar
2018-02-09 9:04 ` Neil Armstrong
2018-02-09 8:58 ` [PATCH 09/10] dt-bindings: cpufreq-dt: Remove "cooling-{min|max}-level" properties Viresh Kumar
2018-02-18 23:26 ` Rob Herring
2018-02-09 8:58 ` [PATCH 10/10] dt-bindings: thermal: " Viresh Kumar
2018-02-18 23:29 ` Rob Herring
2018-02-19 3:43 ` Viresh Kumar
2018-02-19 18:01 ` Rob Herring
2018-03-12 4:38 ` Viresh Kumar
2018-03-20 12:49 ` Zhang Rui
2018-03-27 13:46 ` Eduardo Valentin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5A9975EA.3010306@hisilicon.com \
--to=xuwei5@hisilicon.com \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=edubezval@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=rjw@rjwysocki.net \
--cc=robh+dt@kernel.org \
--cc=rui.zhang@intel.com \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).