* [PATCH] drivers: base: add description for .coredump() callback
@ 2018-02-09 9:13 Arend van Spriel
2018-03-14 9:06 ` Arend van Spriel
0 siblings, 1 reply; 4+ messages in thread
From: Arend van Spriel @ 2018-02-09 9:13 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: LKML, Arend van Spriel
Commit 3c47d19ff4dc ("drivers: base: add coredump driver ops") added
a new callback in struct device_driver, but not a kerneldoc description
so here it is.
Fixes: 3c47d19ff4dc ("drivers: base: add coredump driver ops")
Signed-off-by: Arend van Spriel <aspriel@gmail.com>
---
include/linux/device.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/linux/device.h b/include/linux/device.h
index b093405..0b32a42 100644
--- a/include/linux/device.h
+++ b/include/linux/device.h
@@ -256,6 +256,7 @@ enum probe_type {
* automatically.
* @pm: Power management operations of the device which matched
* this driver.
+ * @coredump: Called through sysfs to initiate a device coredump.
* @p: Driver core's private data, no one other than the driver
* core can touch this.
*
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] drivers: base: add description for .coredump() callback
2018-02-09 9:13 [PATCH] drivers: base: add description for .coredump() callback Arend van Spriel
@ 2018-03-14 9:06 ` Arend van Spriel
2018-03-15 9:32 ` Arend van Spriel
0 siblings, 1 reply; 4+ messages in thread
From: Arend van Spriel @ 2018-03-14 9:06 UTC (permalink / raw)
To: Arend van Spriel, Greg Kroah-Hartman; +Cc: LKML
On 2/9/2018 10:13 AM, Arend van Spriel wrote:
> Commit 3c47d19ff4dc ("drivers: base: add coredump driver ops") added
> a new callback in struct device_driver, but not a kerneldoc description
> so here it is.
Hi Greg,
Revisiting the header file I notice this patch is not yet applied. I am
pretty sure I got an automated email from you regarding the merge
window, but nothing else so did this one slip the cracks?
Regards,
Arend
> Fixes: 3c47d19ff4dc ("drivers: base: add coredump driver ops")
> Signed-off-by: Arend van Spriel <aspriel@gmail.com>
> ---
> include/linux/device.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/linux/device.h b/include/linux/device.h
> index b093405..0b32a42 100644
> --- a/include/linux/device.h
> +++ b/include/linux/device.h
> @@ -256,6 +256,7 @@ enum probe_type {
> * automatically.
> * @pm: Power management operations of the device which matched
> * this driver.
> + * @coredump: Called through sysfs to initiate a device coredump.
> * @p: Driver core's private data, no one other than the driver
> * core can touch this.
> *
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] drivers: base: add description for .coredump() callback
2018-03-14 9:06 ` Arend van Spriel
@ 2018-03-15 9:32 ` Arend van Spriel
2018-03-15 17:27 ` Greg Kroah-Hartman
0 siblings, 1 reply; 4+ messages in thread
From: Arend van Spriel @ 2018-03-15 9:32 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: LKML
On 3/14/2018 10:06 AM, Arend van Spriel wrote:
> On 2/9/2018 10:13 AM, Arend van Spriel wrote:
>> Commit 3c47d19ff4dc ("drivers: base: add coredump driver ops") added
>> a new callback in struct device_driver, but not a kerneldoc description
>> so here it is.
>
> Hi Greg,
>
> Revisiting the header file I notice this patch is not yet applied. I am
> pretty sure I got an automated email from you regarding the merge
> window, but nothing else so did this one slip the cracks?
Hi Greg,
As I am touching this in follow-up patch, can we just drop this one? I
will be posting a couple of new patch assuming it is fine to drop this.
Let me know how you want to handle this.
Regards,
Arend
> Regards,
> Arend
>
>> Fixes: 3c47d19ff4dc ("drivers: base: add coredump driver ops")
>> Signed-off-by: Arend van Spriel <aspriel@gmail.com>
>> ---
>> include/linux/device.h | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/include/linux/device.h b/include/linux/device.h
>> index b093405..0b32a42 100644
>> --- a/include/linux/device.h
>> +++ b/include/linux/device.h
>> @@ -256,6 +256,7 @@ enum probe_type {
>> * automatically.
>> * @pm: Power management operations of the device which matched
>> * this driver.
>> + * @coredump: Called through sysfs to initiate a device coredump.
>> * @p: Driver core's private data, no one other than the driver
>> * core can touch this.
>> *
>>
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] drivers: base: add description for .coredump() callback
2018-03-15 9:32 ` Arend van Spriel
@ 2018-03-15 17:27 ` Greg Kroah-Hartman
0 siblings, 0 replies; 4+ messages in thread
From: Greg Kroah-Hartman @ 2018-03-15 17:27 UTC (permalink / raw)
To: Arend van Spriel; +Cc: LKML
On Thu, Mar 15, 2018 at 10:32:53AM +0100, Arend van Spriel wrote:
> On 3/14/2018 10:06 AM, Arend van Spriel wrote:
> > On 2/9/2018 10:13 AM, Arend van Spriel wrote:
> > > Commit 3c47d19ff4dc ("drivers: base: add coredump driver ops") added
> > > a new callback in struct device_driver, but not a kerneldoc description
> > > so here it is.
> >
> > Hi Greg,
> >
> > Revisiting the header file I notice this patch is not yet applied. I am
> > pretty sure I got an automated email from you regarding the merge
> > window, but nothing else so did this one slip the cracks?
>
> Hi Greg,
>
> As I am touching this in follow-up patch, can we just drop this one? I will
> be posting a couple of new patch assuming it is fine to drop this. Let me
> know how you want to handle this.
Just applied this, it's trivial and should be simple to merge around.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-03-15 17:27 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-02-09 9:13 [PATCH] drivers: base: add description for .coredump() callback Arend van Spriel
2018-03-14 9:06 ` Arend van Spriel
2018-03-15 9:32 ` Arend van Spriel
2018-03-15 17:27 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox