From: Wei Xu <xuwei5@hisilicon.com>
To: Leo Yan <leo.yan@linaro.org>, Jassi Brar <jassisinghbrar@gmail.com>
Cc: Arnd Bergmann <arnd@arndb.de>, Stephen Boyd <sboyd@kernel.org>,
"Kaihua Zhong" <zhongkaihua@huawei.com>,
Tao Wang <kevin.wangtao@hisilicon.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>, <",
linux-arm-kernel"@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>,
srv_heupstream <linux-arm-kernel@lists.infradead.org>,
Devicetree List <devicetree@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Guodong Xu <guodong.xu@linaro.org>,
"Haojian Zhuang" <haojian.zhuang@linaro.org>,
<xuwei5@hisilicon.com>
Subject: Re: [PATCH 5/5] hisi: Consolidate the Kconfigs for the CLOCK_STUB and the MAILBOX
Date: Fri, 11 May 2018 15:05:28 +0100 [thread overview]
Message-ID: <5AF5A328.7080001@hisilicon.com> (raw)
In-Reply-To: <20180509040255.GF23540@leoy-ThinkPad-X240s>
Hi Leo,
On 2018/5/9 5:02, Leo Yan wrote:
> On Wed, May 09, 2018 at 09:19:13AM +0530, Jassi Brar wrote:
>> On Wed, Apr 4, 2018 at 8:44 AM, Leo Yan <leo.yan@linaro.org> wrote:
>>> From: Daniel Lezcano <daniel.lezcano@linaro.org>
>>>
>>> The current defconfig is inconsistent as it selects the mailbox and
>>> the clock for the hi6220 and the hi3660 without having their Kconfigs
>>> making sure the dependencies are correct. It ends up when selecting
>>> different versions for the kernel (for example when git bisecting)
>>> those options disappear and they don't get back, leading to unexpected
>>> behaviors. In our case, the cpufreq driver does no longer work because
>>> the clock fails to initialize due to the clock stub and the mailbox
>>> missing.
>>>
>>> In order to have the dependencies correctly set when defaulting, let's
>>> do the same as commit 3a49afb84ca074e ("clk: enable hi655x common clk
>>> automatically") where we select automatically the driver when the
>>> parent driver is selected. With sensible defaults in place, we can leave
>>> other choices for EXPERT.
>>>
>> Acked-by: Jassi Brar <jaswinder.singh@linaro.org>
>
> Thanks Jassi & Stephen.
>
> Wei, could you pick this patch?
Thanks!
Series applied into the hisilicon tree.
BR,
Wei
>
> Thanks,
> Leo Yan
>
> .
>
prev parent reply other threads:[~2018-05-11 14:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-04 3:14 [PATCH 0/5] Hi3660: enable power management features Leo Yan
2018-04-04 3:14 ` [PATCH 1/5] dts: arm64: hi3660: Add mailbox node Leo Yan
2018-04-04 3:14 ` [PATCH 2/5] dts: arm64: hi3660: Add stub clock node Leo Yan
2018-04-04 3:14 ` [PATCH 3/5] dts: arm64: hi3660: Add CPU frequency scaling support Leo Yan
2018-04-04 3:14 ` [PATCH 4/5] dts: arm64: hi3660: Add thermal cooling management Leo Yan
2018-04-04 3:14 ` [PATCH 5/5] hisi: Consolidate the Kconfigs for the CLOCK_STUB and the MAILBOX Leo Yan
2018-04-07 12:56 ` Stephen Boyd
2018-05-04 14:19 ` Leo Yan
2018-05-09 3:49 ` Jassi Brar
2018-05-09 4:02 ` Leo Yan
2018-05-11 14:05 ` Wei Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5AF5A328.7080001@hisilicon.com \
--to=xuwei5@hisilicon.com \
--cc=", linux-arm-kernel"@lists.infradead.org \
--cc=arnd@arndb.de \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=guodong.xu@linaro.org \
--cc=haojian.zhuang@linaro.org \
--cc=jassisinghbrar@gmail.com \
--cc=kevin.wangtao@hisilicon.com \
--cc=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=sboyd@kernel.org \
--cc=zhongkaihua@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox