From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3F69C433EF for ; Tue, 19 Jun 2018 19:27:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6F72A2083D for ; Tue, 19 Jun 2018 19:27:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="ckm08ug6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6F72A2083D Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S967212AbeFST1M (ORCPT ); Tue, 19 Jun 2018 15:27:12 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:55335 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966747AbeFST1K (ORCPT ); Tue, 19 Jun 2018 15:27:10 -0400 Received: by mail-wm0-f68.google.com with SMTP id v16-v6so2152635wmh.5 for ; Tue, 19 Jun 2018 12:27:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=pqTnXjQ23IYoNc2E7D3+pC0kfdS7LQYkhjJL6uAC46o=; b=ckm08ug6MWS92WEJVXGujJkaNTmecSOPwDnwCm5ZRenaavn/tF3U+6XquMqV5IMgSI z7IjoEU7rVaR0If+VjLIMXCV1IRA50rI0qB460uIFrtMEpwCCgS+MYJA1PPPvgxA0Uzv NLl+syEvMn0iSrrRyKogm7/vWgLvMhNqRVxlc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=pqTnXjQ23IYoNc2E7D3+pC0kfdS7LQYkhjJL6uAC46o=; b=kLSbiF/PPhmXJ/a50NveepNmNksi/1lie7imzySEtMaBZlokLiT66A8NJxNhDaOTXZ qAypTr04Cj8Orh/n2aX79hIVomdAx7HqUiMM33/IbUbeNcCseZSYIg5FyrVso48JbSIT +FNGv65tePWgC0uNlaJmzeHs9dFx3peUlloqEKoNROhLvdjwMlFeGvrQZHFYxs1pxBs9 yysQ0zPS4dP6PPVwIO0p2FRjmOA9cGhcLw9Wf+PkBGoo37c6ty/cXPxL1GYS45mrHstg D6dPhITS3EsG78F5lkKIL426lzSeXxheKE0oy4eYPb6oeBbenqr0e0sIPxe0fCrsDAwJ zKVA== X-Gm-Message-State: APt69E1wvE42JuY3NUgk15mWF9lZBFgz0sH5AAxan4NEtVusXTrsfd3w zbYRWshGrrptXUr7SQQ1JNdPuFtTngM= X-Google-Smtp-Source: ADUXVKKnhKOfCRYmaA4odqirubLli09B53vXQXlaQCnjou7egpqjxeP0w0m5WECF+yoqUT6OOw8b5w== X-Received: by 2002:a50:cc4a:: with SMTP id n10-v6mr15703820edi.171.1529436428983; Tue, 19 Jun 2018 12:27:08 -0700 (PDT) Received: from [192.168.178.129] (f140230.upc-f.chello.nl. [80.56.140.230]) by smtp.gmail.com with ESMTPSA id h4-v6sm281124edn.38.2018.06.19.12.27.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 19 Jun 2018 12:27:07 -0700 (PDT) Subject: Re: [PATCH V2] brcmfmac: stop watchdog before detach and free everything To: Kalle Valo References: <1527493857-2220-1-git-send-email-michael@amarulasolutions.com> <5B0D1C9E.4000800@broadcom.com> <20180530090633.GA15390@panicking> <5B294920.5050909@broadcom.com> <87fu1izjcs.fsf@kamboji.qca.qualcomm.com> Cc: Michael Trimarchi , Franky Lin , Hante Meuleman , Chi-Hsien Lin , Wright Feng , "David S. Miller" , Pieter-Paul Giesberts , Ian Molton , linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, brcm80211-dev-list@cypress.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org From: Arend van Spriel Message-ID: <5B29590C.3040800@broadcom.com> Date: Tue, 19 Jun 2018 21:27:08 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <87fu1izjcs.fsf@kamboji.qca.qualcomm.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/19/2018 9:06 PM, Kalle Valo wrote: > Arend van Spriel writes: > >> On 5/30/2018 11:06 AM, Michael Trimarchi wrote: >>> Using built-in in kernel image without a firmware in filesystem >>> or in the kernel image can lead to a kernel NULL pointer deference. >>> Watchdog need to be stopped in brcmf_sdio_remove >>> >>> The system is going down NOW! >>> [ 1348.110759] Unable to handle kernel NULL pointer dereference at >>> virtual address 000002f8 >>> Sent SIGTERM to all processes >>> [ 1348.121412] Mem abort info: >>> [ 1348.126962] ESR = 0x96000004 >>> [ 1348.130023] Exception class = DABT (current EL), IL = 32 bits >>> [ 1348.135948] SET = 0, FnV = 0 >>> [ 1348.138997] EA = 0, S1PTW = 0 >>> [ 1348.142154] Data abort info: >>> [ 1348.145045] ISV = 0, ISS = 0x00000004 >>> [ 1348.148884] CM = 0, WnR = 0 >>> [ 1348.151861] user pgtable: 4k pages, 48-bit VAs, pgdp = (____ptrval____) >>> [ 1348.158475] [00000000000002f8] pgd=0000000000000000 >>> [ 1348.163364] Internal error: Oops: 96000004 [#1] PREEMPT SMP >>> [ 1348.168927] Modules linked in: ipv6 >>> [ 1348.172421] CPU: 3 PID: 1421 Comm: brcmf_wdog/mmc0 Not tainted >>> 4.17.0-rc5-next-20180517 #18 >>> [ 1348.180757] Hardware name: Amarula A64-Relic (DT) >>> [ 1348.185455] pstate: 60000005 (nZCv daif -PAN -UAO) >>> [ 1348.190251] pc : brcmf_sdiod_freezer_count+0x0/0x20 >>> [ 1348.195124] lr : brcmf_sdio_watchdog_thread+0x64/0x290 >>> [ 1348.200253] sp : ffff00000b85be30 >>> [ 1348.203561] x29: ffff00000b85be30 x28: 0000000000000000 >>> [ 1348.208868] x27: ffff00000b6cb918 x26: ffff80003b990638 >>> [ 1348.214176] x25: ffff0000087b1a20 x24: ffff80003b94f800 >>> [ 1348.219483] x23: ffff000008e620c8 x22: ffff000008f0b660 >>> [ 1348.224790] x21: ffff000008c6a858 x20: 00000000fffffe00 >>> [ 1348.230097] x19: ffff80003b94f800 x18: 0000000000000001 >>> [ 1348.235404] x17: 0000ffffab2e8a74 x16: ffff0000080d7de8 >>> [ 1348.240711] x15: 0000000000000000 x14: 0000000000000400 >>> [ 1348.246018] x13: 0000000000000400 x12: 0000000000000001 >>> [ 1348.251324] x11: 00000000000002c4 x10: 0000000000000a10 >>> [ 1348.256631] x9 : ffff00000b85bc40 x8 : ffff80003be11870 >>> [ 1348.261937] x7 : ffff80003dfc7308 x6 : 000000078ff08b55 >>> [ 1348.267243] x5 : 00000139e1058400 x4 : 0000000000000000 >>> [ 1348.272550] x3 : dead000000000100 x2 : 958f2788d6618100 >>> [ 1348.277856] x1 : 00000000fffffe00 x0 : 0000000000000000 >> >> Forgot about this one. >> >> Acked-by: Arend van Spriel > > Should this go to 4.18? It is a bit of a corner case, but yeah let's do that. Regards, Arend