From: piaojun <piaojun@huawei.com>
To: Dominique Martinet <asmadeus@codewreck.org>, Greg Kurz <groug@kaod.org>
Cc: "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
<v9fs-developer@lists.sourceforge.net>
Subject: Re: [PATCH] net/9p/trans_virtio.c: add a terminal char for mount tag
Date: Thu, 2 Aug 2018 09:18:09 +0800 [thread overview]
Message-ID: <5B625BD1.8050602@huawei.com> (raw)
In-Reply-To: <20180801120958.GA571@nautica>
Hi Dominique and Greg,
Thanks for your reviewing, and I will try to simplify other related code
according your suggestions in patch v2.
Thanks,
Jun
On 2018/8/1 20:09, Dominique Martinet wrote:
> Greg Kurz wrote on Wed, Aug 01, 2018:
>> So this patch basically turns chan->tag into a nul terminated string,
>> which is indeed more convenient and robust. Maybe you can update the
>> rest of the code accordingly and drop chan->tag_len then ?
>
> If we can use that to simplify some other part of the code, that's
> certainly more appealing to me :)
>
>
>> FWIW, 9P strings received from the client are also converted to
>> nul terminated strings:
>
> Oh, good to know; I guess that makes sense when these strings come and
> go from/to other components of the kernel that likely expect that.
>
prev parent reply other threads:[~2018-08-02 1:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-01 7:44 [PATCH] net/9p/trans_virtio.c: add a terminal char for mount tag piaojun
2018-08-01 8:11 ` Dominique Martinet
2018-08-01 8:24 ` piaojun
2018-08-01 10:52 ` Greg Kurz
2018-08-01 12:09 ` Dominique Martinet
2018-08-02 1:18 ` piaojun [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5B625BD1.8050602@huawei.com \
--to=piaojun@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=asmadeus@codewreck.org \
--cc=groug@kaod.org \
--cc=linux-kernel@vger.kernel.org \
--cc=v9fs-developer@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox