From: zhong jiang <zhongjiang@huawei.com>
To: Colin King <colin.king@canonical.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Eric Anholt <eric@anholt.net>, David Airlie <airlied@linux.ie>,
<dri-devel@lists.freedesktop.org>,
<kernel-janitors@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drm/pl111: add in missing sentinel to a of_device_id array
Date: Thu, 23 Aug 2018 19:16:04 +0800 [thread overview]
Message-ID: <5B7E9774.7010500@huawei.com> (raw)
In-Reply-To: <20180821105407.2318-1-colin.king@canonical.com>
Hi, Colin
I has posted the same patch about a month ago. but it seems to be ignored.:-(
https://lore.kernel.org/patchwork/patch/971652/
Thanks,
zhong jiang
On 2018/8/21 18:54, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Array vexpress_muxfpga_match is missing an end of array sentinel,
> add it.
>
> Detected by Coccinelle: ("vexpress_muxfpga_match is not NULL
> terminated at line")
>
> Fixes: ca454bd42dc2 ("drm/pl111: Support the Versatile Express")
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/gpu/drm/pl111/pl111_vexpress.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/pl111/pl111_vexpress.c b/drivers/gpu/drm/pl111/pl111_vexpress.c
> index a534b225e31b..48e2afcd4798 100644
> --- a/drivers/gpu/drm/pl111/pl111_vexpress.c
> +++ b/drivers/gpu/drm/pl111/pl111_vexpress.c
> @@ -111,7 +111,8 @@ static int vexpress_muxfpga_probe(struct platform_device *pdev)
> }
>
> static const struct of_device_id vexpress_muxfpga_match[] = {
> - { .compatible = "arm,vexpress-muxfpga", }
> + { .compatible = "arm,vexpress-muxfpga", },
> + { /* sentinel */ }
> };
>
> static struct platform_driver vexpress_muxfpga_driver = {
next prev parent reply other threads:[~2018-08-23 11:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-21 10:54 [PATCH] drm/pl111: add in missing sentinel to a of_device_id array Colin King
2018-08-23 10:55 ` Linus Walleij
2018-08-23 11:16 ` zhong jiang [this message]
2018-08-28 20:46 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5B7E9774.7010500@huawei.com \
--to=zhongjiang@huawei.com \
--cc=airlied@linux.ie \
--cc=colin.king@canonical.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=eric@anholt.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox