[PATCH] gpu: do not double put device node in zx_drm_probe

[PATCH] gpu: do not double put device node in zx_drm_probe

[zhong jiang]

for_each_available_child_of_node will get and put the node properly,
the following of_node_put will lead to the double put. So just
remove it.

Signed-off-by: zhong jiang <zhongjiang@huawei.com>
---
 drivers/gpu/drm/zte/zx_drm_drv.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/zte/zx_drm_drv.c b/drivers/gpu/drm/zte/zx_drm_drv.c
index 6f4205e8..d7b9870 100644
--- a/drivers/gpu/drm/zte/zx_drm_drv.c
+++ b/drivers/gpu/drm/zte/zx_drm_drv.c
@@ -161,10 +161,8 @@ static int zx_drm_probe(struct platform_device *pdev)
 	if (ret)
 		return ret;
 
-	for_each_available_child_of_node(parent, child) {
+	for_each_available_child_of_node(parent, child)
 		component_match_add(dev, &match, compare_of, child);
-		of_node_put(child);
-	}
 
 	return component_master_add_with_match(dev, &zx_drm_master_ops, match);
 }
-- 
1.7.12.4

Re: [PATCH] gpu: do not double put device node in zx_drm_probe

[zhong jiang]

Ping,  Anyone has any objections a about the patch?

Best wishes,
zhong jiang
On 2018/8/17 10:24, zhong jiang wrote:
> for_each_available_child_of_node will get and put the node properly,
> the following of_node_put will lead to the double put. So just
> remove it.
>
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
> ---
>  drivers/gpu/drm/zte/zx_drm_drv.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/zte/zx_drm_drv.c b/drivers/gpu/drm/zte/zx_drm_drv.c
> index 6f4205e8..d7b9870 100644
> --- a/drivers/gpu/drm/zte/zx_drm_drv.c
> +++ b/drivers/gpu/drm/zte/zx_drm_drv.c
> @@ -161,10 +161,8 @@ static int zx_drm_probe(struct platform_device *pdev)
>  	if (ret)
>  		return ret;
>  
> -	for_each_available_child_of_node(parent, child) {
> +	for_each_available_child_of_node(parent, child)
>  		component_match_add(dev, &match, compare_of, child);
> -		of_node_put(child);
> -	}
>  
>  	return component_master_add_with_match(dev, &zx_drm_master_ops, match);
>  }

Re: [PATCH] gpu: do not double put device node in zx_drm_probe

[Shawn Guo]

On Fri, Aug 17, 2018 at 10:24:06AM +0800, zhong jiang wrote:
> for_each_available_child_of_node will get and put the node properly,
> the following of_node_put will lead to the double put. So just
> remove it.
> 
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>

Acked-by: Shawn Guo <shawnguo@kernel.org>

Re: [PATCH] gpu: do not double put device node in zx_drm_probe

[Daniel Vetter]

On Mon, Aug 27, 2018 at 9:18 AM, Shawn Guo <shawnguo@kernel.org> wrote:
> On Fri, Aug 17, 2018 at 10:24:06AM +0800, zhong jiang wrote:
>> for_each_available_child_of_node will get and put the node properly,
>> the following of_node_put will lead to the double put. So just
>> remove it.
>>
>> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
>
> Acked-by: Shawn Guo <shawnguo@kernel.org>

Shawn, I'm assuming you'll push this to drm-misc-next? You're the
maintainer with commit rights after all.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch

Re: [PATCH] gpu: do not double put device node in zx_drm_probe

[Shawn Guo]

On Tue, Sep 18, 2018 at 05:19:09PM +0200, Daniel Vetter wrote:
> On Mon, Aug 27, 2018 at 9:18 AM, Shawn Guo <shawnguo@kernel.org> wrote:
> > On Fri, Aug 17, 2018 at 10:24:06AM +0800, zhong jiang wrote:
> >> for_each_available_child_of_node will get and put the node properly,
> >> the following of_node_put will lead to the double put. So just
> >> remove it.
> >>
> >> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
> >
> > Acked-by: Shawn Guo <shawnguo@kernel.org>
> 
> Shawn, I'm assuming you'll push this to drm-misc-next? You're the
> maintainer with commit rights after all.

Just pushed to drm-misc-next.  Sorry for the delay.

Shawn

Re: [PATCH] gpu: do not double put device node in zx_drm_probe

[zhong jiang]

+to maintainer.
On 2018/8/17 10:24, zhong jiang wrote:
> for_each_available_child_of_node will get and put the node properly,
> the following of_node_put will lead to the double put. So just
> remove it.
>
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>gg
> ---
>  drivers/gpu/drm/zte/zx_drm_drv.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/zte/zx_drm_drv.c b/drivers/gpu/drm/zte/zx_drm_drv.c
> index 6f4205e8..d7b9870 100644
> --- a/drivers/gpu/drm/zte/zx_drm_drv.c
> +++ b/drivers/gpu/drm/zte/zx_drm_drv.c
> @@ -161,10 +161,8 @@ static int zx_drm_probe(struct platform_device *pdev)
>  	if (ret)
>  		return ret;
>  
> -	for_each_available_child_of_node(parent, child) {
> +	for_each_available_child_of_node(parent, child)
>  		component_match_add(dev, &match, compare_of, child);
> -		of_node_put(child);
> -	}
>  
>  	return component_master_add_with_match(dev, &zx_drm_master_ops, match);
>  }

Re: [PATCH] gpu: do not double put device node in zx_drm_probe

[zhong jiang]

Hi,  Greg

Can you pick up the patch? 

Thanks,
zhong jiang 

On 2018/8/17 10:24, zhong jiang wrote:
> for_each_available_child_of_node will get and put the node properly,
> the following of_node_put will lead to the double put. So just
> remove it.
>
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
> ---
>  drivers/gpu/drm/zte/zx_drm_drv.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/zte/zx_drm_drv.c b/drivers/gpu/drm/zte/zx_drm_drv.c
> index 6f4205e8..d7b9870 100644
> --- a/drivers/gpu/drm/zte/zx_drm_drv.c
> +++ b/drivers/gpu/drm/zte/zx_drm_drv.c
> @@ -161,10 +161,8 @@ static int zx_drm_probe(struct platform_device *pdev)
>  	if (ret)
>  		return ret;
>  
> -	for_each_available_child_of_node(parent, child) {
> +	for_each_available_child_of_node(parent, child)
>  		component_match_add(dev, &match, compare_of, child);
> -		of_node_put(child);
> -	}
>  
>  	return component_master_add_with_match(dev, &zx_drm_master_ops, match);
>  }

Re: [PATCH] gpu: do not double put device node in zx_drm_probe

[Greg KH]

On Tue, Sep 18, 2018 at 10:59:08PM +0800, zhong jiang wrote:
> Hi,  Greg
> 
> Can you pick up the patch? 

Nope:
$ ./scripts/get_maintainer.pl --file drivers/gpu/drm/zte/zx_drm_drv.c
Shawn Guo <shawnguo@kernel.org> (maintainer:DRM DRIVERS FOR ZTE ZX)
David Airlie <airlied@linux.ie> (maintainer:DRM DRIVERS)
dri-devel@lists.freedesktop.org (open list:DRM DRIVERS FOR ZTE ZX)
linux-kernel@vger.kernel.org (open list)

why would I take thi when all of those others are the correct
maintainers?

Also, you only posted this 1 day ago.  Please relax and give people time
and a chance to review your patch.  It is not instant.

thanks,

greg k-h

Re: [PATCH] gpu: do not double put device node in zx_drm_probe

[zhong jiang]

On 2018/9/18 23:02, Greg KH wrote:
> On Tue, Sep 18, 2018 at 10:59:08PM +0800, zhong jiang wrote:
>> Hi,  Greg
>>
>> Can you pick up the patch? 
> Nope:
> $ ./scripts/get_maintainer.pl --file drivers/gpu/drm/zte/zx_drm_drv.c
> Shawn Guo <shawnguo@kernel.org> (maintainer:DRM DRIVERS FOR ZTE ZX)
> David Airlie <airlied@linux.ie> (maintainer:DRM DRIVERS)
> dri-devel@lists.freedesktop.org (open list:DRM DRIVERS FOR ZTE ZX)
> linux-kernel@vger.kernel.org (open list)
>
> why would I take thi when all of those others are the correct
> maintainers?
>
> Also, you only posted this 1 day ago.  Please relax and give people time
> and a chance to review your patch.  It is not instant.
No,  I posted the patch a month ago.  I have sent a ping. but It do not work. :-( . 

Thanks,
zhong jiang
> thanks,
>
> greg k-h
>
> .
>

Re: [PATCH] gpu: do not double put device node in zx_drm_probe

[Daniel Vetter]

On Tue, Sep 18, 2018 at 5:02 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Tue, Sep 18, 2018 at 10:59:08PM +0800, zhong jiang wrote:
>> Hi,  Greg
>>
>> Can you pick up the patch?
>
> Nope:
> $ ./scripts/get_maintainer.pl --file drivers/gpu/drm/zte/zx_drm_drv.c
> Shawn Guo <shawnguo@kernel.org> (maintainer:DRM DRIVERS FOR ZTE ZX)
> David Airlie <airlied@linux.ie> (maintainer:DRM DRIVERS)
> dri-devel@lists.freedesktop.org (open list:DRM DRIVERS FOR ZTE ZX)
> linux-kernel@vger.kernel.org (open list)
>
> why would I take thi when all of those others are the correct
> maintainers?
>
> Also, you only posted this 1 day ago.  Please relax and give people time
> and a chance to review your patch.  It is not instant.

First submission was in August, acked by Shawn, but somehow they
forgot to actually push the patch out. I pinged Shawn.

Thanks, Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch