From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8C60C433F4 for ; Wed, 19 Sep 2018 11:32:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F2DD62150D for ; Wed, 19 Sep 2018 11:32:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F2DD62150D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731515AbeISRKD (ORCPT ); Wed, 19 Sep 2018 13:10:03 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:12623 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1731247AbeISRKC (ORCPT ); Wed, 19 Sep 2018 13:10:02 -0400 Received: from DGGEMS406-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 4913B5159AFB8; Wed, 19 Sep 2018 19:32:30 +0800 (CST) Received: from [127.0.0.1] (10.177.29.68) by DGGEMS406-HUB.china.huawei.com (10.3.19.206) with Microsoft SMTP Server id 14.3.399.0; Wed, 19 Sep 2018 19:32:28 +0800 Message-ID: <5BA233CB.3070401@huawei.com> Date: Wed, 19 Sep 2018 19:32:27 +0800 From: zhong jiang User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:12.0) Gecko/20120428 Thunderbird/12.0.1 MIME-Version: 1.0 To: Christian Borntraeger CC: , , , , , , Ursula Braun , Julian Wiedmann Subject: Re: [PATCH 1/5] net: iucv: Use FIELD_SIZEOF directly instead of reimplementing its function References: <1537352781-48532-1-git-send-email-zhongjiang@huawei.com> <1537352781-48532-2-git-send-email-zhongjiang@huawei.com> In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.177.29.68] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2018/9/19 19:21, Christian Borntraeger wrote: > Can you please copy Ursula and Julian for iucv related patches? Thanks, Maybe I forget cc more maintainer. So I will resend in v2. Sincerely, zhong jiang > On 09/19/2018 12:26 PM, zhong jiang wrote: >> FIELD_SIZEOF is defined as a macro to calculate the specified value. Therefore, >> We prefer to use the macro rather than calculating its value. >> >> Signed-off-by: zhong jiang >> --- >> net/iucv/af_iucv.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/net/iucv/af_iucv.c b/net/iucv/af_iucv.c >> index e2f16a0..5b68ee9 100644 >> --- a/net/iucv/af_iucv.c >> +++ b/net/iucv/af_iucv.c >> @@ -48,7 +48,7 @@ >> static const u8 iprm_shutdown[8] = >> {0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x01}; >> >> -#define TRGCLS_SIZE (sizeof(((struct iucv_message *)0)->class)) >> +#define TRGCLS_SIZE FIELD_SIZEOF(struct iucv_message, class) >> >> #define __iucv_sock_wait(sk, condition, timeo, ret) \ >> do { \ >> > >