From: zhong jiang <zhongjiang@huawei.com>
To: Todor Tomov <todor.tomov@linaro.org>
Cc: <mchehab@kernel.org>, <linux-media@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] media: qcom: remove duplicated include file
Date: Fri, 21 Sep 2018 11:36:34 +0800 [thread overview]
Message-ID: <5BA46742.4010804@huawei.com> (raw)
In-Reply-To: <43b41757-18ea-cbb3-1578-ba4068b13ab1@linaro.org>
On 2018/9/20 13:55, Todor Tomov wrote:
> Thank you for spotting that!
>
> On 19.09.2018 21:59, zhong jiang wrote:
>> device.h have duplicated include. hence just remove
>> redundant include file.
> I think it will be better to remove the second occurrence because
> it will keep the alphabetical order of the includes.
Yep, I forget the point. Will change in v2.
Thanks,
zhong jiang
> Best regards,
> Todor Tomov
>
>> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
>> ---
>> drivers/media/platform/qcom/camss/camss.h | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/media/platform/qcom/camss/camss.h b/drivers/media/platform/qcom/camss/camss.h
>> index 418996d..0823a71 100644
>> --- a/drivers/media/platform/qcom/camss/camss.h
>> +++ b/drivers/media/platform/qcom/camss/camss.h
>> @@ -10,7 +10,6 @@
>> #ifndef QC_MSM_CAMSS_H
>> #define QC_MSM_CAMSS_H
>>
>> -#include <linux/device.h>
>> #include <linux/types.h>
>> #include <media/v4l2-async.h>
>> #include <media/v4l2-device.h>
>>
>
>
prev parent reply other threads:[~2018-09-21 3:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-20 4:59 [PATCH] media: qcom: remove duplicated include file zhong jiang
2018-09-20 5:55 ` Todor Tomov
2018-09-21 3:36 ` zhong jiang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5BA46742.4010804@huawei.com \
--to=zhongjiang@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=todor.tomov@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox