* [PATCH] media: qcom: remove duplicated include file
@ 2018-09-20 4:59 zhong jiang
2018-09-20 5:55 ` Todor Tomov
0 siblings, 1 reply; 3+ messages in thread
From: zhong jiang @ 2018-09-20 4:59 UTC (permalink / raw)
To: mchehab; +Cc: todor.tomov, linux-media, linux-kernel
device.h have duplicated include. hence just remove
redundant include file.
Signed-off-by: zhong jiang <zhongjiang@huawei.com>
---
drivers/media/platform/qcom/camss/camss.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/media/platform/qcom/camss/camss.h b/drivers/media/platform/qcom/camss/camss.h
index 418996d..0823a71 100644
--- a/drivers/media/platform/qcom/camss/camss.h
+++ b/drivers/media/platform/qcom/camss/camss.h
@@ -10,7 +10,6 @@
#ifndef QC_MSM_CAMSS_H
#define QC_MSM_CAMSS_H
-#include <linux/device.h>
#include <linux/types.h>
#include <media/v4l2-async.h>
#include <media/v4l2-device.h>
--
1.7.12.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] media: qcom: remove duplicated include file
2018-09-20 4:59 [PATCH] media: qcom: remove duplicated include file zhong jiang
@ 2018-09-20 5:55 ` Todor Tomov
2018-09-21 3:36 ` zhong jiang
0 siblings, 1 reply; 3+ messages in thread
From: Todor Tomov @ 2018-09-20 5:55 UTC (permalink / raw)
To: zhong jiang; +Cc: mchehab, linux-media, linux-kernel
Thank you for spotting that!
On 19.09.2018 21:59, zhong jiang wrote:
> device.h have duplicated include. hence just remove
> redundant include file.
I think it will be better to remove the second occurrence because
it will keep the alphabetical order of the includes.
Best regards,
Todor Tomov
>
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
> ---
> drivers/media/platform/qcom/camss/camss.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/media/platform/qcom/camss/camss.h b/drivers/media/platform/qcom/camss/camss.h
> index 418996d..0823a71 100644
> --- a/drivers/media/platform/qcom/camss/camss.h
> +++ b/drivers/media/platform/qcom/camss/camss.h
> @@ -10,7 +10,6 @@
> #ifndef QC_MSM_CAMSS_H
> #define QC_MSM_CAMSS_H
>
> -#include <linux/device.h>
> #include <linux/types.h>
> #include <media/v4l2-async.h>
> #include <media/v4l2-device.h>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] media: qcom: remove duplicated include file
2018-09-20 5:55 ` Todor Tomov
@ 2018-09-21 3:36 ` zhong jiang
0 siblings, 0 replies; 3+ messages in thread
From: zhong jiang @ 2018-09-21 3:36 UTC (permalink / raw)
To: Todor Tomov; +Cc: mchehab, linux-media, linux-kernel
On 2018/9/20 13:55, Todor Tomov wrote:
> Thank you for spotting that!
>
> On 19.09.2018 21:59, zhong jiang wrote:
>> device.h have duplicated include. hence just remove
>> redundant include file.
> I think it will be better to remove the second occurrence because
> it will keep the alphabetical order of the includes.
Yep, I forget the point. Will change in v2.
Thanks,
zhong jiang
> Best regards,
> Todor Tomov
>
>> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
>> ---
>> drivers/media/platform/qcom/camss/camss.h | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/media/platform/qcom/camss/camss.h b/drivers/media/platform/qcom/camss/camss.h
>> index 418996d..0823a71 100644
>> --- a/drivers/media/platform/qcom/camss/camss.h
>> +++ b/drivers/media/platform/qcom/camss/camss.h
>> @@ -10,7 +10,6 @@
>> #ifndef QC_MSM_CAMSS_H
>> #define QC_MSM_CAMSS_H
>>
>> -#include <linux/device.h>
>> #include <linux/types.h>
>> #include <media/v4l2-async.h>
>> #include <media/v4l2-device.h>
>>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-09-21 3:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-09-20 4:59 [PATCH] media: qcom: remove duplicated include file zhong jiang
2018-09-20 5:55 ` Todor Tomov
2018-09-21 3:36 ` zhong jiang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox