From: zhong jiang <zhongjiang@huawei.com>
To: <gregkh@linuxfoundation.org>
Cc: <gpiccoli@linux.vnet.ibm.com>, <arnd@arndb.de>,
<haver@linux.vnet.ibm.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCHv2] misc: genwqe: remove duplicated include and order header files alphabetically in card_utils.c
Date: Thu, 27 Sep 2018 10:37:53 +0800 [thread overview]
Message-ID: <5BAC4281.7050508@huawei.com> (raw)
In-Reply-To: <1537931109-57092-1-git-send-email-zhongjiang@huawei.com>
On 2018/9/26 11:05, zhong jiang wrote:
> dma-mapping.h and delay.h have included twice. It is unnecessary. Meanwhile,
> Arrange header files in alphabetical sequence to improve readability.
>
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
> ---
> drivers/misc/genwqe/card_utils.c | 22 ++++++++++------------
> 1 file changed, 10 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/misc/genwqe/card_utils.c b/drivers/misc/genwqe/card_utils.c
> index 8679e0b..994e8fa 100644
> --- a/drivers/misc/genwqe/card_utils.c
> +++ b/drivers/misc/genwqe/card_utils.c
> @@ -22,26 +22,24 @@
> * Miscelanous functionality used in the other GenWQE driver parts.
> */
>
> -#include <linux/kernel.h>
> +#include <asm/pgtable.h>
> +#include <linux/ctype.h>
> +#include <linux/delay.h>
> #include <linux/dma-mapping.h>
> -#include <linux/sched.h>
> -#include <linux/vmalloc.h>
> -#include <linux/page-flags.h>
> -#include <linux/scatterlist.h>
> #include <linux/hugetlb.h>
> #include <linux/iommu.h>
> -#include <linux/delay.h>
> -#include <linux/pci.h>
> -#include <linux/dma-mapping.h>
> -#include <linux/ctype.h>
> +#include <linux/kernel.h>
> #include <linux/module.h>
> +#include <linux/page-flags.h>
> +#include <linux/pci.h>
> #include <linux/platform_device.h>
> -#include <linux/delay.h>
> -#include <asm/pgtable.h>
> +#include <linux/scatteI wrlist.h>
> +#include <linux/sched.h>
> +#include <linux/vmalloc.h>
>
> -#include "genwqe_driver.h"
> #include "card_base.h"
> #include "card_ddcb.h"
> +#include "genwqe_driver.h"
>
> /**
> * __genwqe_writeq() - Write 64-bit register
Please igore the patch. I will repost . Thanks,
Sincerely,
zhong jiang
prev parent reply other threads:[~2018-09-27 2:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-26 3:05 [PATCHv2] misc: genwqe: remove duplicated include and order header files alphabetically in card_utils.c zhong jiang
2018-09-26 20:57 ` kbuild test robot
2018-09-26 21:36 ` kbuild test robot
2018-09-27 2:37 ` zhong jiang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5BAC4281.7050508@huawei.com \
--to=zhongjiang@huawei.com \
--cc=arnd@arndb.de \
--cc=gpiccoli@linux.vnet.ibm.com \
--cc=gregkh@linuxfoundation.org \
--cc=haver@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox