From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f178.google.com (mail-dy1-f178.google.com [74.125.82.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 29278EEA8 for ; Sun, 26 Apr 2026 18:47:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777229233; cv=none; b=OVH22G4jCe14sXDdDurV5LX/niyXiEH48hPU0iH492OSVvuuX3y01GIqSiSsjsgO8LGFt31LcZ7IYbBf4/PtOqtxTZhr74LrEGm7y38nrQfW967XZlvVrtooEcle3ncl0mPALniEf1yyHQNYlFdIioBjy06K7YHVWVr6cQ6G9AA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777229233; c=relaxed/simple; bh=40f7rEFqR6Ug5kyMHD2r7DHdyHOW+wmg2jDCZuu+QJ4=; h=Date:From:To:CC:Subject:In-Reply-To:References:Message-ID: MIME-Version:Content-Type; b=I9tbybcB+jV5J/EM4AwWvtc3bfqhR71aUw4rUOBtXA6fpnCqWJMOoxr81vfSfFS150vOZTICwYWJjhGYj35UgJ0RTT6P9r4KXYXGQEMCJ0dEK/Zv1UF50bcgagYN5T/2TsoVvgXf4d2/BsMl0IYaxkidHcFGErvnoBzliDwFjK8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=m5Va3Sbs; arc=none smtp.client-ip=74.125.82.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="m5Va3Sbs" Received: by mail-dy1-f178.google.com with SMTP id 5a478bee46e88-2c15849aa2cso12446993eec.0 for ; Sun, 26 Apr 2026 11:47:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777229231; x=1777834031; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:user-agent:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to; bh=O8ZvOUiwDu16iFcd+HoNf/DK6B/xDXTpW2Inyx4d500=; b=m5Va3Sbsb1xv0TcETamb//Hqj40L+nbR42J5018laN+IfB9WofZ2C9plBkqn4/UvW3 F79yniHqGuhTG+73T7NkjQ6cSZ3xvQSmoEYpKKAPAZLBXSPJuaviXFFLi2cE3P9B0W6k SenR5MBXQIXtpH8/AyHyh3V35wL5NNovjWIiGJnbeA2tavfM3fvR+Jmqb5f27LvlvuMG nd4sugPOy4+PPRgRf9IIi7mXApciKc95rUW/n6pZTo6iVV0ZDC9uV0rDMmkRbQuXpDlm 9rEdi4Yn7l6LoDhVj+86G6RYRAyd5TCrAo5n+rIwcSvS+Gn5gxnuO8Z7s+R44D0qzdp2 n5MA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777229231; x=1777834031; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:user-agent:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=O8ZvOUiwDu16iFcd+HoNf/DK6B/xDXTpW2Inyx4d500=; b=PlIHPGapjvjCRK3no2En7lo3vojrlFDipytn8QKKWqtzVkN7cpp5SewuBmwGWuSRMS ZjZFB1HS9G7ILyhNEP5yt0B1+D29My0Y4l3DCLPl0BuMPj8wS4FeTWr/iwyHKSnzxzdR 0cYjvYaOeRRiBkg1dVJW0LdZDWP4/rUaI9/NH1bHQoSgXBMEItTpCEJIFd9hO+t+zU3A 76PShSP+eu7E6ELG+M8iIhAjQ87IxWbMlab49YzR0hfm7FOGXw9LdxwWWnhIh5fa92yO rpJs8UDuVsVqgCPlGqAT5rXRFH9dt+iYoxdLEs87EzpVsVZ6TAqLSHF/2QdlmWqGZWCd OFbQ== X-Forwarded-Encrypted: i=1; AFNElJ9vURx7K9xDazt6iLSm3jVWAwbXKV8v6sXXCFgHH5wRVeI/sESuOQHOGmIN2AEPaNEsIhCYFWXYwgMOPCk=@vger.kernel.org X-Gm-Message-State: AOJu0Yw+qCZ8jW6H0IrMRBF4hVDy/HfYnYTN28i2UNAu/EVdwxN7PrYg c5Y2g+wBmQ4fg6JbkO6uiaGSisycrIYzxFq//FwNXLOyCQaWe87KPMpx X-Gm-Gg: AeBDieuLSnm9Otm81Ryk6RZGY6bqXwvYsbz//5DrqV+vi72epiG/l6Q5HZBdCJJETCT sPi0NmwfYYQRXsb30fugnkGO12gaBqv/8eNezzJToztcvfg9wtXsqL6/rfielP+hCgUJ5UjS/3S KChrSPce3wfhExlhZ21wYVHjx0I0mnmFV2Utv3YGDxw6wi578SX35IZLAYkgXrFGen3K9+dBn+Z Fq/hgG4W8w2uQSYaIHcWSZ4uEMeg1dJ5UHJFMz8lrgh3nA19juwEI19P5q8o/+I0JJNYoFpTtB7 hcXmaneSH/Nvsko7q70nNYsNPvH16ua+Tvx+HhdndVY04OnF2op9IkhrMmqCO1umk3/BP8jKz34 FPEuE8WDKQkrvoblrUX+NuzUbiN6NSKxqBHPrHv32uLdFMWEOAydcv3BK9Uj0BO3b2SgGqTZI5r PQfsbJ/cH/4sQSdxsIiWqdsWqno1xgBLg7NWpTeco27R9mAbIxcI1GzL/GQQTFFvbFVRKekSEaI vdegSWUj2gFZ3rFf0vcBZ6sEniln6G0 X-Received: by 2002:a05:7300:5997:b0:2ea:cd38:f921 with SMTP id 5a478bee46e88-2eacd391c70mr6146770eec.26.1777229231195; Sun, 26 Apr 2026 11:47:11 -0700 (PDT) Received: from ehlo.thunderbird.net (108-228-232-20.lightspeed.sndgca.sbcglobal.net. [108.228.232.20]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2e53ac84c38sm41712334eec.13.2026.04.26.11.47.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 26 Apr 2026 11:47:10 -0700 (PDT) Date: Sun, 26 Apr 2026 11:47:10 -0700 From: "Derek J. Clark" To: no name , mpearson-lenovo@squebb.ca, i@rong.moe CC: hansg@kernel.org, ilpo.jarvinen@linux.intel.com, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] platform/x86: lenovo: wmi-other: Fix uninitialized User-Agent: Thunderbird for Android In-Reply-To: References: <673b66893c16ca31b403e7e7cba32e9b71a7515a.camel@rong.moe> <20260426174332.9981-1-cd345al@gmail.com> Message-ID: <5BB41C4A-12DC-4059-9C97-CBBA4226DFC6@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On April 26, 2026 11:38:35 AM PDT, no name wrote: >Hi, Derek, >Thanks for your reply! > >On Mon, Apr 27, 2026 at 2:22=E2=80=AFAM Derek J=2E Clark > wrote: >> Hi Yufei, >> >> This bug is already addressed in a patch series that has been submitted= and is awaiting review from the subsystem maintainers=2E >> >Which bug do you mean specifically? The args=2Earg1 uninitialized bug, >or the original uninitialized 'raw' variable, or the inappropriate >encapsulation? I was replying to that specific part of your email, regarding the args in= itializing=2E=20 See Thanks, Derek >> >I may do some refactor recently, and I'm happy to hear your suggestion= s=2E >> >> Rong has a large refactor series queued up to simplify much of the driv= er already, pending the acceptance of the previously mentioned series=2E It= would be best to avoid doing any additional large refactoring until that s= eries has landed=2E >> >OK, that sounds good=2E I'll wait until the refactor is done=2E I hope my >suggestions can be adopted or we can discuss further about the >appropriate architecture=2E I'm happy to hear your suggestions=2E > >Thanks, >Yufei