From: Pascal PAILLET-LME <p.paillet@st.com>
To: Axel Lin <axel.lin@ingics.com>, Mark Brown <broonie@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] regulator: stpmic1: Return REGULATOR_MODE_INVALID for invalid mode
Date: Thu, 18 Oct 2018 09:12:01 +0000 [thread overview]
Message-ID: <5BC84E60.60501@st.com> (raw)
In-Reply-To: <20181009085221.31137-1-axel.lin@ingics.com>
Hi Axel,
Thank you for your comment. As the driver is merged, I will make the
change in a future patch-set.
Best regards, Pascal.
Le 10/09/2018 10:52 AM, Axel Lin a écrit :
> -EINVAL is not a valid return value for .of_map_mode, return
> REGULATOR_MODE_INVALID instead.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> drivers/regulator/stpmic1_regulator.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/regulator/stpmic1_regulator.c b/drivers/regulator/stpmic1_regulator.c
> index 96f18083a3b6..e15634edb8ce 100644
> --- a/drivers/regulator/stpmic1_regulator.c
> +++ b/drivers/regulator/stpmic1_regulator.c
> @@ -441,7 +441,7 @@ static unsigned int stpmic1_map_mode(unsigned int mode)
> case STPMIC1_BUCK_MODE_LP:
> return REGULATOR_MODE_STANDBY;
> default:
> - return -EINVAL;
> + return REGULATOR_MODE_INVALID;
> }
> }
>
prev parent reply other threads:[~2018-10-18 9:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-09 8:52 [PATCH] regulator: stpmic1: Return REGULATOR_MODE_INVALID for invalid mode Axel Lin
2018-10-18 9:12 ` Pascal PAILLET-LME [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5BC84E60.60501@st.com \
--to=p.paillet@st.com \
--cc=axel.lin@ingics.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox