public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Thorsten Blum <thorsten.blum@linux.dev>
To: Jan Kara <jack@suse.cz>
Cc: Christian Brauner <brauner@kernel.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] acl: Realign struct posix_acl to reduce its size by 8 bytes
Date: Fri, 4 Oct 2024 22:11:00 +0200	[thread overview]
Message-ID: <5BDFB946-8E51-4A8F-B7F8-40290FCB0011@linux.dev> (raw)
In-Reply-To: <20241004133716.enkqnmosn42oagos@quack3>

On 4. Oct 2024, at 15:37, Jan Kara wrote:
> On Fri 04-10-24 12:33:57, Thorsten Blum wrote:
>> Reduce posix_acl's struct size by 8 bytes by realigning its members.
>> 
>> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
> 
> Looks good. Feel free to add:
> 
> Reviewed-by: Jan Kara <jack@suse.cz>

We should probably add:

Fixes: b0ab04a8ffd8 ("acl: Annotate struct posix_acl with __counted_by()")
Reported-by: kernel test robot <oliver.sang@intel.com>
Closes: https://lore.kernel.org/oe-lkp/202409260949.a1254989-oliver.sang@intel.com

as this patch is also a workaround for a Clang __bdos() bug (see the
Closes: link for details).

Thanks,
Thorsten

  reply	other threads:[~2024-10-04 20:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-04 10:33 [PATCH] acl: Realign struct posix_acl to reduce its size by 8 bytes Thorsten Blum
2024-10-04 13:37 ` Jan Kara
2024-10-04 20:11   ` Thorsten Blum [this message]
2024-10-04 21:12     ` Thorsten Blum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5BDFB946-8E51-4A8F-B7F8-40290FCB0011@linux.dev \
    --to=thorsten.blum@linux.dev \
    --cc=brauner@kernel.org \
    --cc=jack@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox