* [PATCH] mfd: hi655x-pmic: Fix missing return value check for devm_regmap_init_mmio_clk
@ 2019-03-06 13:49 Axel Lin
2019-03-07 1:44 ` Chen Feng
0 siblings, 1 reply; 2+ messages in thread
From: Axel Lin @ 2019-03-06 13:49 UTC (permalink / raw)
To: Lee Jones; +Cc: Chen Feng, linux-kernel, Axel Lin
Since devm_regmap_init_mmio_clk can fail, add return value checking.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/mfd/hi655x-pmic.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/mfd/hi655x-pmic.c b/drivers/mfd/hi655x-pmic.c
index 96c07fa1802a..6693f74aa6ab 100644
--- a/drivers/mfd/hi655x-pmic.c
+++ b/drivers/mfd/hi655x-pmic.c
@@ -112,6 +112,8 @@ static int hi655x_pmic_probe(struct platform_device *pdev)
pmic->regmap = devm_regmap_init_mmio_clk(dev, NULL, base,
&hi655x_regmap_config);
+ if (IS_ERR(pmic->regmap))
+ return PTR_ERR(pmic->regmap);
regmap_read(pmic->regmap, HI655X_BUS_ADDR(HI655X_VER_REG), &pmic->ver);
if ((pmic->ver < PMU_VER_START) || (pmic->ver > PMU_VER_END)) {
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] mfd: hi655x-pmic: Fix missing return value check for devm_regmap_init_mmio_clk
2019-03-06 13:49 [PATCH] mfd: hi655x-pmic: Fix missing return value check for devm_regmap_init_mmio_clk Axel Lin
@ 2019-03-07 1:44 ` Chen Feng
0 siblings, 0 replies; 2+ messages in thread
From: Chen Feng @ 2019-03-07 1:44 UTC (permalink / raw)
To: Axel Lin, Lee Jones; +Cc: linux-kernel
Thanks
On 2019/3/6 21:49, Axel Lin wrote:
> Since devm_regmap_init_mmio_clk can fail, add return value checking.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> drivers/mfd/hi655x-pmic.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/mfd/hi655x-pmic.c b/drivers/mfd/hi655x-pmic.c
> index 96c07fa1802a..6693f74aa6ab 100644
> --- a/drivers/mfd/hi655x-pmic.c
> +++ b/drivers/mfd/hi655x-pmic.c
> @@ -112,6 +112,8 @@ static int hi655x_pmic_probe(struct platform_device *pdev)
>
> pmic->regmap = devm_regmap_init_mmio_clk(dev, NULL, base,
> &hi655x_regmap_config);
> + if (IS_ERR(pmic->regmap))
> + return PTR_ERR(pmic->regmap);
>
> regmap_read(pmic->regmap, HI655X_BUS_ADDR(HI655X_VER_REG), &pmic->ver);
> if ((pmic->ver < PMU_VER_START) || (pmic->ver > PMU_VER_END)) {
>
--
Cheers,
- Feng
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-03-07 1:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-06 13:49 [PATCH] mfd: hi655x-pmic: Fix missing return value check for devm_regmap_init_mmio_clk Axel Lin
2019-03-07 1:44 ` Chen Feng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox