From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40E50C43381 for ; Sat, 16 Mar 2019 14:41:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1027621903 for ; Sat, 16 Mar 2019 14:41:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="JPJ9XkWI" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727087AbfCPOlb (ORCPT ); Sat, 16 Mar 2019 10:41:31 -0400 Received: from mail-wr1-f66.google.com ([209.85.221.66]:34787 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726861AbfCPOlb (ORCPT ); Sat, 16 Mar 2019 10:41:31 -0400 Received: by mail-wr1-f66.google.com with SMTP id k1so11975291wre.1 for ; Sat, 16 Mar 2019 07:41:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-transfer-encoding; bh=3JRLm6aE8nn8AvGA5lUY5WZdl5snm2+VkOvlXdbMgtI=; b=JPJ9XkWIO8HUDvxFf+kq39rqA4rHHGIIFiEcw67Q7gKsJq0mcMInQ+A6zyjIcEBy2l BgLOYZPerTuO0DKcGe9vq9E5RvrH2BpS6omPPX2rav1bIgy+KdgXvJ+MNkx7UKI38q+X jvJdrcyr3fhhFU9EyNGZ3MTDH4QbDXhI89t6FNjxBj087O+2ETozMRqN1uQXJJ5m3xNI HzI3/Oi0Bral0ihWSAWRFa/R5OcgkZr8Ykmvrtvo1pzV/rIdyqGOBDaqUE6QYYJAlMh2 Xs3pue3fqjuy95eVMpmPchiMq9TTWb4spc3H6wFW6yfevoj8MKRzJyHl77k8eWHbXpSv 96Ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-transfer-encoding; bh=3JRLm6aE8nn8AvGA5lUY5WZdl5snm2+VkOvlXdbMgtI=; b=oAdB20YSpvWhnAQQeP75hmhr/jzl+5W1F5c/1BJ9EBDr8B4ZnILpi8Nq3qeT0IWGki xEuZjBoSd9WZt+Ljkzhw8ocikT5RzRMCMw3vXUWta/1bxMhwZB8Z7cga9qUyItQ+fZVr GKih8ykJNeY4CduuK4lmissoZzpFmQNuv75Hox4/walAxXjb9a9PNXdATnaQM9h4rY0o JcK834Jb6A+AIa4H+6J6PL4X4gi0dHYIFXiRF+5634Q1c+tTcJmXZV5LPuMzdgJHrTuU K6G9VaDPB2YHYphoIogItjMBXiWkoMT9xGN12tVYOvQRbgtWuUaGPyTCDrGKjCTwWeEl 28Sg== X-Gm-Message-State: APjAAAXbMChJ9jDS5TX9R29cbrq0Afv8EcnTgNiG/VKsRPCkaqSIhy93 S7C9abgIj18YEMXv1izfP6YYt+RFpZeyXA== X-Google-Smtp-Source: APXvYqxJTlTq+VQ5O/KmnNSLpkSECzgV79OMiHzEa8PG0yPJOhl4AaBhfbjnFDbTV8Zx+wTNYtb/CA== X-Received: by 2002:adf:efc8:: with SMTP id i8mr6360395wrp.164.1552747289844; Sat, 16 Mar 2019 07:41:29 -0700 (PDT) Received: from [192.168.1.77] (176-150-251-154.abo.bbox.fr. [176.150.251.154]) by smtp.gmail.com with ESMTPSA id r6sm4955723wrx.48.2019.03.16.07.41.28 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 16 Mar 2019 07:41:29 -0700 (PDT) Message-ID: <5C8D0B18.1070001@baylibre.com> Date: Sat, 16 Mar 2019 15:41:28 +0100 From: Neil Armstrong User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Martin Blumenstingl , Guillaume La Roque CC: khilman@baylibre.com, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 06/11] arm64: dts: meson-g12a-x96-max: add regulators References: <20190311095613.11371-1-narmstrong@baylibre.com> <20190311095613.11371-7-narmstrong@baylibre.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 15/03/2019 23:05, Martin Blumenstingl a écrit : > Hi Neil and Guillaume, > > On Mon, Mar 11, 2019 at 11:04 AM Neil Armstrong wrote: >> >> From: Guillaume La Roque >> >> Add system regulators for the X96 Max Set-Top-Box. > the hint from the "meson-g12a-sei510: add regulators" patch would be > great here as well: > Still missing > * VDD_EE (0.8V - PWM controlled) > * VDD_CPU(PWM controlled) > * VDDQ1_5 Will add the comment > > I'm not sure whether this board also has VDDQ1_5 though, but VDD_EE > and VDD_CPU should be very similar (or even identical) It's bases on a ref design, we can assume it's the same yes > >> >> Signed-off-by: Guillaume La Roque >> Signed-off-by: Neil Armstrong >> --- >> .../boot/dts/amlogic/meson-g12a-x96-max.dts | 65 +++++++++++++++++++ >> 1 file changed, 65 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dts b/arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dts >> index 0edbd00b358f..21e5de48613e 100644 >> --- a/arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dts >> +++ b/arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dts >> @@ -21,6 +21,71 @@ >> device_type = "memory"; >> reg = <0x0 0x0 0x0 0x40000000>; >> }; >> + >> + flash_1v8: regulator-flash_1v8 { >> + compatible = "regulator-fixed"; >> + regulator-name = "FLASH_1V8"; >> + regulator-min-microvolt = <1800000>; >> + regulator-max-microvolt = <1800000>; >> + vin-supply = <&vcc_3v3>; >> + regulator-always-on; >> + }; >> + >> + main_12v: regulator-main_12v { >> + compatible = "regulator-fixed"; >> + regulator-name = "12V"; >> + regulator-min-microvolt = <12000000>; >> + regulator-max-microvolt = <12000000>; >> + regulator-always-on; >> + }; > mine has a 5V DC in. can you please check this on your board? > > > Regards > Martin >